blob: 3669e36843188d3e20ed62583e33970251a77bd9 [file] [log] [blame]
Ed Tanousd5cea142021-09-09 11:42:05 -07001#!/bin/bash -e
2#
3
Ed Tanous7f8954e2021-09-09 11:46:43 -07004script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
5obmc_dir=${script_dir}/../../
6
Patrick Williams12a27b22021-10-26 16:07:31 -05007cd "$obmc_dir"
8
Ed Tanous7f8954e2021-09-09 11:46:43 -07009# openbmc doesn't control what upstream poky, or any of the other layers do,
10# which do use patches as part of their upstreaming process.
11# meta-phosphor is also included such that patches that the community agrees to
12# hold onto will be allowed in that layer.
13
14patch_files_tmp=$(mktemp)
15allowed_patches_tmp=$(mktemp)
Patrick Williams693d3db2021-10-26 16:10:20 -050016trap 'rm $patch_files_tmp $allowed_patches_tmp' exit
Ed Tanous7f8954e2021-09-09 11:46:43 -070017
Patrick Williams12a27b22021-10-26 16:07:31 -050018git ls-files -- \
Ed Tanous7f8954e2021-09-09 11:46:43 -070019 '*.patch' \
20 ':!:poky/**' \
Brad Bishopbec4ebc2022-08-03 09:55:16 -040021 ':!:meta-arm/**' \
Ed Tanous7f8954e2021-09-09 11:46:43 -070022 ':!:meta-security/**' \
Ed Tanous7f8954e2021-09-09 11:46:43 -070023 ':!:meta-raspberrypi/**' \
24 ':!:meta-openembedded/**' \
25 ':!:meta-phosphor/**' \
Patrick Williams693d3db2021-10-26 16:10:20 -050026 | sort > "$patch_files_tmp"
Ed Tanous7f8954e2021-09-09 11:46:43 -070027
28
29# The following patches were present on master at the time this test was
30# written. Their presence in this list should not be acknowlegement that they
31# are now allowed, but ignoring them is required in the intermediate time
32# between when this test was created, and when the maintainers of these repos
33# clean them up.
34#
35# https://github.com/openbmc/docs/blob/master/meta-layer-guidelines.md
36echo "\
37meta-amd/meta-ethanolx/recipes-x86/chassis/x86-power-control/0001-Amd-power-control-modifications-for-EthanolX.patch
38meta-ampere/meta-common/recipes-devtools/mtd/mtd-utils/0001-flashcp-support-offset-option.patch
Ed Tanous7f8954e2021-09-09 11:46:43 -070039meta-aspeed/recipes-bsp/u-boot/files/default-gcc.patch
Ed Tanous7f8954e2021-09-09 11:46:43 -070040meta-bytedance/meta-g220a/recipes-kernel/linux/linux-aspeed/0005-ARM-dts-aspeed-Enable-g220a-uart-route.patch
41meta-bytedance/meta-g220a/recipes-phosphor/ipmi/phosphor-node-manager-proxy/0001-Remove-Total_Power-sensor.patch
42meta-facebook/meta-bletchley/recipes-bsp/u-boot/u-boot-aspeed-sdk/0001-u-boot-ast2600-57600-baudrate-for-bletchley.patch
43meta-facebook/meta-tiogapass/recipes-bsp/u-boot/u-boot-aspeed/0001-configs-ast-common-use-57600-baud-rate-to-match-Tiog.patch
Logananth Sundararaj971257a2022-03-23 17:34:12 +053044meta-facebook/meta-yosemitev2/recipes-bsp/u-boot/u-boot-aspeed-sdk/0001-board-aspeed-Add-Mux-for-yosemitev2.patch
45meta-facebook/meta-yosemitev2/recipes-bsp/u-boot/u-boot-aspeed-sdk/0002-spl-host-console-handle.patch
Ed Tanous7f8954e2021-09-09 11:46:43 -070046meta-google/dynamic-layers/nuvoton-layer/recipes-bsp/images/npcm7xx-igps/0001-Set-FIU0_DRD_CFG-and-FIU_Clk_divider-for-gbmc-hoth.patch
47meta-google/recipes-extended/libconfig/files/0001-conf2struct-Use-the-right-perl.patch
48meta-google/recipes-extended/libconfig/files/0001-makefile-Add-missing-LDFLAGS.patch
49meta-google/recipes-phosphor/initrdscripts/obmc-phosphor-initfs/rwfs-clean-dev.patch
50meta-ingrasys/meta-zaius/recipes-bsp/u-boot/u-boot-aspeed/0001-board-aspeed-Add-reset_phy-for-Zaius.patch
51meta-nuvoton/recipes-bsp/images/npcm7xx-igps/0001-Adjust-paths-for-use-with-Bitbake.patch
Tim Lee1c9c10a2022-07-05 17:14:18 +080052meta-nuvoton/recipes-bsp/images/npcm8xx-igps/0001-Adjust-paths-for-use-with-Bitbake.patch
Ed Tanous7f8954e2021-09-09 11:46:43 -070053meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0001-Add-system-reset-status-support.patch
54meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0002-config-ast-common-set-fieldmode-to-true.patch
55meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0003-aspeed-add-gpio-support.patch
56meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0004-aspeed-add-bmc-position-support.patch
57meta-yadro/meta-nicole/recipes-kernel/linux/linux-aspeed/0001-Add-NCSI-channel-selector.patch
58meta-yadro/meta-nicole/recipes-phosphor/host/op-proc-control/0001-Stop-and-send-SRESET-for-one-thread-only.patch
59meta-yadro/recipes-phosphor/dbus/phosphor-dbus-interfaces/0001-Add-boot-initiator-mailbox-interface.patch
60meta-yadro/recipes-phosphor/ipmi/phosphor-ipmi-host/0001-Add-support-for-persistent-only-settings.patch
61meta-yadro/recipes-phosphor/ipmi/phosphor-ipmi-host/0002-Add-support-for-boot-initiator-mailbox.patch
62meta-yadro/recipes-phosphor/ipmi/phosphor-ipmi-host/0003-Fix-version-parsing-update-AUX-revision-info.patch
Patrick Williams693d3db2021-10-26 16:10:20 -050063" | sort > "$allowed_patches_tmp"
Ed Tanous7f8954e2021-09-09 11:46:43 -070064
Patrick Williams693d3db2021-10-26 16:10:20 -050065files_diff=$(comm -23 "$patch_files_tmp" "$allowed_patches_tmp")
Ed Tanous7f8954e2021-09-09 11:46:43 -070066
Ed Tanous4734c222021-09-20 11:11:34 -070067files_count=$(echo -n "$files_diff" | grep -c '^' || true)
Ed Tanous7f8954e2021-09-09 11:46:43 -070068if [[ $files_count -ne 0 ]]; then
69 echo "Patch files found not in allow list"
70 echo "$files_diff"
71 echo "Patches are not allowed on OpenBMC in these layers. Please upstream your changes and see \
72 https://github.com/openbmc/docs/blob/master/meta-layer-guidelines.md"
73 exit 1
74fi
75
Andrew Geisslerfc328172022-01-21 09:37:06 -060076# Now verify there are no kernel dts files being added in a patch
77# All dts files should be sent upstream and can be carried in the openbmc/linux
78# tree until they are accepted upstream
79dts_files_tmp=$(mktemp)
80allowed_dts_tmp=$(mktemp)
81trap 'rm $dts_files_tmp $allowed_dts_tmp' exit
82
83git ls-files -- \
84 '*.dts' \
85 ':!:poky/**' \
Brad Bishopbec4ebc2022-08-03 09:55:16 -040086 ':!:meta-arm/**' \
Andrew Geisslerfc328172022-01-21 09:37:06 -060087 ':!:meta-security/**' \
88 ':!:meta-raspberrypi/**' \
89 ':!:meta-openembedded/**' \
90 | sort > "$dts_files_tmp"
91
92# There is a single dts currently in the tree that we will exempt for now
93echo "\
94meta-hpe/meta-dl360poc/recipes-kernel/linux/linux-obmc/gxp.dts
95" | sort > "$allowed_dts_tmp"
96
97files_diff=$(comm -23 "$dts_files_tmp" "$allowed_dts_tmp")
98
99files_count=$(echo -n "$files_diff" | grep -c '^' || true)
100if [[ $files_count -ne 0 ]]; then
101echo "Dts files found not in allow list"
102echo "$files_diff"
103echo "Dts files are not allowed on OpenBMC in these layers. Please upstream your changes and see \
104 https://github.com/openbmc/docs/blob/master/kernel-development.md"
105exit 1
106fi
107
Patrick Williams12a27b22021-10-26 16:07:31 -0500108lint_exempt="\
109meta-amd/recipes-amd/amd-fpga/files/ethanolx/fpgardu.sh
Patrick Williams12a27b22021-10-26 16:07:31 -0500110meta-bytedance/meta-g220a/recipes-network/network/static-mac-addr/mac-check
111meta-bytedance/meta-g220a/recipes-phosphor/datetime/me-time-sync/me-time-sync.sh
Patrick Williams12a27b22021-10-26 16:07:31 -0500112meta-google/recipes-google/gpio/gpio-ctrl/lib.sh
113meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/host_isoff.sh
114meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/host_powercycle.sh
115meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/host_poweroff.sh
116meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/host_poweron.sh
117meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/host_reset.sh
118meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/lib.sh
119meta-google/recipes-google/ipmi/ipmi-fru-sh/lib.sh
120meta-google/recipes-google/ncsi/files/gbmc-ncsi-ip-from-ra.sh.in
121meta-google/recipes-google/networking/files/gbmc-ip-monitor-test.sh
122meta-google/recipes-google/networking/files/gbmc-ip-monitor.sh
123meta-google/recipes-google/networking/files/gbmc-mac-config.sh.in
Patrick Williams521d8f62021-10-27 09:30:41 -0500124meta-google/recipes-google/networking/gbmc-bridge/gbmc-br-from-ra.sh
125meta-google/recipes-google/networking/gbmc-bridge/gbmc-br-gw-src.sh
126meta-google/recipes-google/networking/gbmc-bridge/gbmc-br-nft.sh
127meta-google/recipes-google/networking/gbmc-bridge/gbmc-br-ula.sh
Patrick Williams12a27b22021-10-26 16:07:31 -0500128meta-google/recipes-google/networking/google-usb-network/usb_network.sh
129meta-google/recipes-google/networking/google-usb-network/usb_network_test.sh
130meta-google/recipes-google/networking/network-sh/lib.sh
131meta-google/recipes-google/networking/network-sh/test.sh
132meta-google/recipes-google/nftables/files/nft-configure.sh
133meta-google/recipes-google/ssh/authorized-keys-comp/authorized-keys-comp.sh
134meta-google/recipes-google/test/test-sh/test.sh
135meta-google/recipes-phosphor/flash/google-key/verify-bmc-image.sh
136meta-google/recipes-phosphor/flash/inplace-gbmc-update/inplace-gbmc-verify.sh
137meta-hpe/meta-common/recipes-hpe/host/host-boot-enable/host-boot-enable.sh
138meta-hpe/meta-common/recipes-phosphor/initrdscripts/files/gxp-obmc-init.sh
139meta-hpe/meta-dl360poc/recipes-hpe/host/host-boot-enable/host-boot-enable.sh
140meta-ibm/meta-romulus/recipes-phosphor/chassis/vrm-control/vrm-control.sh
141meta-ibm/meta-romulus/recipes-phosphor/gpio/id-button/toggle_identify_led.sh
142meta-ibm/recipes-phosphor/chassis/power-workarounds/witherspoon/power-workarounds.sh
143meta-ibm/recipes-phosphor/chassis/vrm-control/ibm-ac-server/ir35221-unbind-bind.sh
144meta-ibm/recipes-phosphor/chassis/vrm-control/mihawk/ir35221-unbind-bind.sh
145meta-ibm/recipes-phosphor/chassis/vrm-control/vrm-control.sh
146meta-ibm/recipes-phosphor/dump/phosphor-debug-collector/plugins.d/ibm_elogall
147meta-ibm/recipes-phosphor/dump/phosphor-debug-collector/plugins.d/pels
148meta-ibm/recipes-phosphor/gpio/id-button/toggle_identify_led.sh
149meta-ibm/recipes-phosphor/mboxd/mboxd/check_pnor_format.sh
150meta-ingrasys/meta-zaius/recipes-phosphor/chassis/avsbus-control/zaius_avsbus.sh
151meta-ingrasys/meta-zaius/recipes-phosphor/chassis/vcs-control/zaius_vcs.sh
152meta-inventec/meta-transformers/recipes-phosphor/init/transformers-init/transformers-init.sh
Patrick Williams521d8f62021-10-27 09:30:41 -0500153meta-openpower/recipes-bsp/pdata/files/power-target.sh
Patrick Williams12a27b22021-10-26 16:07:31 -0500154meta-openpower/recipes-phosphor/dump/phosphor-debug-collector/plugins.d/guard
155meta-openpower/recipes-phosphor/network/first-boot-set-hostname/first-boot-set-hostname.sh
156meta-openpower/recipes-phosphor/network/first-boot-set-mac/first-boot-set-mac.sh
157meta-openpower/recipes-phosphor/occ/openpower-occ-control/occ-active.sh
158meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-init.sh
159meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-shutdown.sh
160meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-update.sh
161meta-phosphor/recipes-phosphor/initrdscripts/phosphor-mmc-init/mmc-init.sh
162meta-phosphor/recipes-phosphor/interfaces/bmcweb/run-ptest
163meta-phosphor/recipes-phosphor/preinit-mounts/preinit-mounts/init
164meta-phosphor/recipes-support/nss-pam-ldapd/files/nslcd.init
Patrick Williams12a27b22021-10-26 16:07:31 -0500165meta-quanta/meta-common/recipes-quanta/network/usb-network/usb-network.sh
166meta-quanta/meta-gbs/recipes-gbs/gbs-bios-update/files/bios-update.sh
167meta-quanta/meta-gbs/recipes-gbs/gbs-bios-update/files/bios-verify.sh
168meta-quanta/meta-gbs/recipes-gbs/gbs-bmc-update/files/bmc-verify.sh
169meta-quanta/meta-gbs/recipes-gbs/gbs-detect-gpio-present/files/detect-gpio-present.sh
170meta-quanta/meta-gbs/recipes-gbs/gbs-sysinit/files/gbs-sysinit.sh
171meta-quanta/meta-gbs/recipes-gbs/hotswap-power-cycle/files/tray_powercycle.sh
172meta-quanta/meta-gbs/recipes-google/acpi-power-state/acpi-power-state-daemon/gbs-check-host-state.sh
173meta-quanta/meta-gbs/recipes-google/acpi-power-state/acpi-power-state-daemon/gbs-set-failsafe.sh
174meta-quanta/meta-gbs/recipes-phosphor/fans/phosphor-pid-control/fan-table-init.sh
175meta-quanta/meta-gbs/recipes-phosphor/sensors/phosphor-nvme/nvme_json_rewrite.sh
176meta-quanta/meta-gsj/recipes-gsj/detect-fan-fail/files/detect-fan-fail.sh
177meta-quanta/meta-gsj/recipes-gsj/gsj-hotswap-change-setting/files/gsj-hotswap-change-setting.sh
178meta-quanta/meta-gsj/recipes-gsj/quanta-nvme-powerctrl/files/init_once.sh
179meta-quanta/meta-gsj/recipes-gsj/quanta-nvme-powerctrl/files/nvme_powerctrl_library.sh
180meta-quanta/meta-gsj/recipes-gsj/quanta-nvme-powerctrl/files/nvme_powermanager.sh
181meta-quanta/meta-gsj/recipes-gsj/usb-network/files/usb_network.sh
182meta-quanta/meta-gsj/recipes-phosphor/fans/phosphor-pid-control/fan-control.sh
Patrick Williams521d8f62021-10-27 09:30:41 -0500183meta-quanta/meta-gsj/recipes-phosphor/fans/phosphor-pid-control/fan-default-speed.sh
Patrick Williams12a27b22021-10-26 16:07:31 -0500184meta-quanta/meta-olympus-nuvoton/recipes-olympus-nuvoton/power/first-boot-set-psu/first-boot-set-psu.sh
Patrick Williams521d8f62021-10-27 09:30:41 -0500185meta-quanta/meta-olympus-nuvoton/recipes-phosphor/fans/phosphor-pid-control/fan-full-speed.sh
Patrick Williams12a27b22021-10-26 16:07:31 -0500186meta-quanta/meta-q71l/recipes-phosphor/quanta-powerctrl/files/init_once.sh
187meta-quanta/meta-q71l/recipes-phosphor/quanta-powerctrl/files/poweroff.sh
188meta-quanta/meta-q71l/recipes-phosphor/quanta-powerctrl/files/poweron.sh
189meta-yadro/meta-nicole/recipes-phosphor/chassis/avsbus-control/avsbus-control.sh
Patrick Williams12a27b22021-10-26 16:07:31 -0500190"
191
Patrick Williams2ed00d82021-10-27 09:33:53 -0500192types=(json shell)
193# shellcheck disable=SC2034
194check_json="eslint --resolve-plugins-relative-to /usr/local/lib/node_modules"
Patrick Williams521d8f62021-10-27 09:30:41 -0500195# shellcheck disable=SC2034
196check_shell="shellcheck -x"
197
198for t in "${types[@]}"; do
199 check_cmd="check_${t}"
200 if ! which "${!check_cmd%% *}" > /dev/null 2>&1; then
201 eval "${check_cmd}=\"echo WARNING: Skipping $t due to missing command:\""
202 echo "${!check_cmd}"
203 fi
204done
205
Patrick Williams12a27b22021-10-26 16:07:31 -0500206non_bbfiles=$(git ls-files -- \
207 ':!:poky/**' \
Brad Bishopbec4ebc2022-08-03 09:55:16 -0400208 ':!:meta-arm/**' \
Patrick Williams12a27b22021-10-26 16:07:31 -0500209 ':!:meta-security/**' \
210 ':!:meta-raspberrypi/**' \
211 ':!:meta-openembedded/**' \
212 | grep -v -e "\.patch$" -e "\.bb$" -e "\.bbappend$")
213
214for f in $non_bbfiles; do
Patrick Williams521d8f62021-10-27 09:30:41 -0500215 unset file_type
216 file_info=$(file "$f")
217 case $file_info in
Patrick Williams12a27b22021-10-26 16:07:31 -0500218 *shell\ script*)
Patrick Williams521d8f62021-10-27 09:30:41 -0500219 file_type="shell"
Patrick Williams12a27b22021-10-26 16:07:31 -0500220 ;;
221
Patrick Williams2ed00d82021-10-27 09:33:53 -0500222 *JSON\ data*)
223 file_type="json"
224 ;;
225
Patrick Williams12a27b22021-10-26 16:07:31 -0500226 *)
Patrick Williams521d8f62021-10-27 09:30:41 -0500227 case $f in
228 *.sh)
229 file_type="shell"
230 ;;
231
Patrick Williams2ed00d82021-10-27 09:33:53 -0500232 *.json)
233 file_type="json"
234 ;;
Patrick Williams521d8f62021-10-27 09:30:41 -0500235 esac
Patrick Williams12a27b22021-10-26 16:07:31 -0500236 esac
Patrick Williams521d8f62021-10-27 09:30:41 -0500237
238 if [ -n "$file_type" ]; then
239 check_cmd="check_${file_type}"
240 if ! eval "${!check_cmd} $f"; then
241 if [[ $lint_exempt == *$f* ]]; then
242 echo "EXEMPT: $f"
243 else
244 echo "FAILED: $f"
245 false
246 fi
247 fi
248 fi
249
Patrick Williams12a27b22021-10-26 16:07:31 -0500250done
251
Ed Tanousd5cea142021-09-09 11:42:05 -0700252echo "Repo test passed"