blob: 68ba556485e1348dabe5eb3061cc5ca65fdfc3de [file] [log] [blame]
Brad Bishopc342db32019-05-15 21:57:59 -04001#
2# SPDX-License-Identifier: MIT
3#
4
Brad Bishopd7bf8c12018-02-25 22:55:05 -05005from oeqa.selftest.case import OESelftestTestCase
6from oeqa.utils.commands import runCmd, bitbake, get_bb_var, get_bb_vars
7from oeqa.utils.decorators import testcase
8from oeqa.utils.ftools import write_file
Brad Bishopd7bf8c12018-02-25 22:55:05 -05009
Brad Bishop19323692019-04-05 15:28:33 -040010import oe.recipeutils
11
Brad Bishopd7bf8c12018-02-25 22:55:05 -050012class Distrodata(OESelftestTestCase):
13
Brad Bishopd7bf8c12018-02-25 22:55:05 -050014 def test_checkpkg(self):
15 """
16 Summary: Test that upstream version checks do not regress
17 Expected: Upstream version checks should succeed except for the recipes listed in the exception list.
18 Product: oe-core
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080019 Author: Alexander Kanavin <alex.kanavin@gmail.com>
Brad Bishopd7bf8c12018-02-25 22:55:05 -050020 """
Brad Bishop19323692019-04-05 15:28:33 -040021 feature = 'LICENSE_FLAGS_WHITELIST += " commercial"\n'
22 self.write_config(feature)
23
24 pkgs = oe.recipeutils.get_recipe_upgrade_status()
25
26 regressed_failures = [pkg[0] for pkg in pkgs if pkg[1] == 'UNKNOWN_BROKEN']
27 regressed_successes = [pkg[0] for pkg in pkgs if pkg[1] == 'KNOWN_BROKEN']
Brad Bishopd7bf8c12018-02-25 22:55:05 -050028 msg = ""
29 if len(regressed_failures) > 0:
30 msg = msg + """
31The following packages failed upstream version checks. Please fix them using UPSTREAM_CHECK_URI/UPSTREAM_CHECK_REGEX
32(when using tarballs) or UPSTREAM_CHECK_GITTAGREGEX (when using git). If an upstream version check cannot be performed
33(for example, if upstream does not use git tags), you can set UPSTREAM_VERSION_UNKNOWN to '1' in the recipe to acknowledge
34that the check cannot be performed.
35""" + "\n".join(regressed_failures)
36 if len(regressed_successes) > 0:
37 msg = msg + """
38The following packages have been checked successfully for upstream versions,
39but their recipes claim otherwise by setting UPSTREAM_VERSION_UNKNOWN. Please remove that line from the recipes.
40""" + "\n".join(regressed_successes)
41 self.assertTrue(len(regressed_failures) == 0 and len(regressed_successes) == 0, msg)
Brad Bishop316dfdd2018-06-25 12:45:53 -040042
43 def test_maintainers(self):
44 """
45 Summary: Test that oe-core recipes have a maintainer
46 Expected: All oe-core recipes (except a few special static/testing ones) should have a maintainer listed in maintainers.inc file.
47 Product: oe-core
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080048 Author: Alexander Kanavin <alex.kanavin@gmail.com>
Brad Bishop316dfdd2018-06-25 12:45:53 -040049 """
50 def is_exception(pkg):
51 exceptions = ["packagegroup-", "initramfs-", "systemd-machine-units", "target-sdk-provides-dummy"]
52 for i in exceptions:
53 if i in pkg:
54 return True
55 return False
56
Brad Bishop19323692019-04-05 15:28:33 -040057 feature = 'require conf/distro/include/maintainers.inc\n'
58 self.write_config(feature)
Brad Bishop316dfdd2018-06-25 12:45:53 -040059
Brad Bishop19323692019-04-05 15:28:33 -040060 with bb.tinfoil.Tinfoil() as tinfoil:
61 tinfoil.prepare(config_only=False)
Brad Bishop316dfdd2018-06-25 12:45:53 -040062
Brad Bishop19323692019-04-05 15:28:33 -040063 with_maintainer_list = []
64 no_maintainer_list = []
65 # We could have used all_recipes() here, but this method will find
66 # every recipe if we ever move to setting RECIPE_MAINTAINER in recipe files
67 # instead of maintainers.inc
68 for fn in tinfoil.all_recipe_files(variants=False):
69 if not '/meta/recipes-' in fn:
70 # We are only interested in OE-Core
71 continue
72 rd = tinfoil.parse_recipe_file(fn, appends=False)
73 pn = rd.getVar('PN')
74 if is_exception(pn):
75 continue
76 if rd.getVar('RECIPE_MAINTAINER'):
77 with_maintainer_list.append((pn, fn))
78 else:
79 no_maintainer_list.append((pn, fn))
Brad Bishop316dfdd2018-06-25 12:45:53 -040080
Brad Bishop19323692019-04-05 15:28:33 -040081 if no_maintainer_list:
82 self.fail("""
83The following recipes do not have a maintainer assigned to them. Please add an entry to meta/conf/distro/include/maintainers.inc file.
84""" + "\n".join(['%s (%s)' % i for i in no_maintainer_list]))
Brad Bishop316dfdd2018-06-25 12:45:53 -040085
Brad Bishop19323692019-04-05 15:28:33 -040086 if not with_maintainer_list:
87 self.fail("""
88The list of oe-core recipes with maintainers is empty. This may indicate that the test has regressed and needs fixing.
89""")