| Patrick Williams | b48b7b4 | 2016-08-17 15:04:38 -0500 | [diff] [blame] | 1 | From 738a9857be9c92ad2f70be88ccee238e3154a936 Mon Sep 17 00:00:00 2001 |
| 2 | From: Joe MacDonald <joe.macdonald@windriver.com> |
| 3 | Date: Wed, 2 Oct 2013 14:20:37 -0400 |
| 4 | Subject: [PATCH] racoon/pfkey: avoid potential null-pointer dereference |
| 5 | |
| 6 | Building with -Werror=maybe-uninitialized revealed that 'remote' from |
| 7 | pk_recvmigrate() could be used with uninitialized data in |
| 8 | migrate_sp_ike_addresses(). Ensure it is always at a minimum assigned |
| 9 | NULL. |
| 10 | |
| 11 | Upstream-Status: Pending |
| 12 | |
| 13 | Signed-off-by: Joe MacDonald <joe.macdonald@windriver.com> |
| 14 | --- |
| 15 | src/racoon/pfkey.c | 2 +- |
| 16 | 1 file changed, 1 insertion(+), 1 deletion(-) |
| 17 | |
| 18 | diff --git a/src/racoon/pfkey.c b/src/racoon/pfkey.c |
| 19 | index d00b166..e0dc1db 100644 |
| 20 | --- a/src/racoon/pfkey.c |
| 21 | +++ b/src/racoon/pfkey.c |
| 22 | @@ -3352,7 +3352,7 @@ pk_recvmigrate(mhp) |
| 23 | struct sockaddr *old_saddr, *new_saddr; |
| 24 | struct sockaddr *old_daddr, *new_daddr; |
| 25 | struct sockaddr *old_local, *old_remote; |
| 26 | - struct sockaddr *local, *remote; |
| 27 | + struct sockaddr *local, *remote = NULL; |
| 28 | struct sadb_x_kmaddress *kmaddr; |
| 29 | struct sadb_x_policy *xpl; |
| 30 | struct sadb_x_ipsecrequest *xisr_list; |
| 31 | -- |
| 32 | 1.7.9.5 |
| 33 | |