Brad Bishop | 1932369 | 2019-04-05 15:28:33 -0400 | [diff] [blame] | 1 | From b8862e6af1c6d022b8c182098e7deddb874ece19 Mon Sep 17 00:00:00 2001 |
| 2 | From: Khem Raj <raj.khem@gmail.com> |
| 3 | Date: Tue, 18 Dec 2018 23:10:44 -0800 |
| 4 | Subject: [PATCH] Do not pass null string to %s printf formatted string |
| 5 | |
| 6 | Here the string is already decided to be NULL and passing |
| 7 | a null pointer to %s will not work |
| 8 | |
| 9 | Fixes |
| 10 | error: '%s' directive argument is null |
| 11 | |
| 12 | Upstream-Status: Submitted [https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/67] |
| 13 | |
| 14 | Signed-off-by: Khem Raj <raj.khem@gmail.com> |
| 15 | --- |
| 16 | plugins/mtk/mm-broadband-modem-mtk.c | 2 +- |
| 17 | 1 file changed, 1 insertion(+), 1 deletion(-) |
| 18 | |
| 19 | diff --git a/plugins/mtk/mm-broadband-modem-mtk.c b/plugins/mtk/mm-broadband-modem-mtk.c |
| 20 | index 475a63ac..541de4a5 100644 |
| 21 | --- a/plugins/mtk/mm-broadband-modem-mtk.c |
| 22 | +++ b/plugins/mtk/mm-broadband-modem-mtk.c |
| 23 | @@ -191,7 +191,7 @@ get_supported_modes_ready (MMBaseModem *self, |
| 24 | |
| 25 | response = mm_base_modem_at_command_finish (MM_BASE_MODEM (self), res, &error); |
| 26 | if (!response) { |
| 27 | - mm_dbg ("Fail to get response %s", response); |
| 28 | + mm_dbg ("Fail to get response"); |
| 29 | g_task_return_error (task, error); |
| 30 | g_object_unref (task); |
| 31 | return; |