blob: 1b196db81a3447063ad79a5143e7dc1b4ee4ea4f [file] [log] [blame]
Andrew Geisslerc9f78652020-09-18 14:11:35 -05001From 60864efbe52cc12018efaafbc4e4c3c8b4af2b65 Mon Sep 17 00:00:00 2001
Brad Bishop1a4b7ee2018-12-16 17:11:34 -08002From: Otavio Salvador <otavio@ossystems.com.br>
3Date: Thu, 5 Jul 2018 10:26:48 -0300
Brad Bishop08902b02019-08-20 09:16:51 -04004Subject: [PATCH] Fail silently if system Qt installation is broken
Brad Bishop1a4b7ee2018-12-16 17:11:34 -08005
6Fixes a regression in behaviour from 2.8.10 to 2.8.11 resulting in the
7following error if the system Qt installation is broken:
8
9CMake Error at Modules/FindQt4.cmake:1028 (set_property):
10 set_property could not find TARGET Qt4::QtCore. Perhaps it has not yet
11 been created.
12Call Stack (most recent call first):
13 Tests/RunCMake/CMakeLists.txt:79 (find_package)
14
15Upstream-Status: Pending
16
17Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
18
19The patch was slightly adapted in order to match cmake 3.2.2:
20Another set_property was introduced which had to be included
21within the if(QT_QTCORE_FOUND) statement.
22
23Signed-off-by: Moritz Blume <moritz.blume@bmw-carit.de>
24Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Brad Bishop08902b02019-08-20 09:16:51 -040025
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080026---
27 Modules/FindQt4.cmake | 39 ++++++++++++++++++++-------------------
28 1 file changed, 20 insertions(+), 19 deletions(-)
29
30diff --git a/Modules/FindQt4.cmake b/Modules/FindQt4.cmake
Andrew Geissler82c905d2020-04-13 13:39:40 -050031index b2a8585..77c89aa 100644
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080032--- a/Modules/FindQt4.cmake
33+++ b/Modules/FindQt4.cmake
Brad Bishop19323692019-04-05 15:28:33 -040034@@ -988,25 +988,26 @@ if (QT_QMAKE_EXECUTABLE AND
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080035 endif()
36 endmacro()
37
38-
39- # Set QT_xyz_LIBRARY variable and add
40- # library include path to QT_INCLUDES
41- _QT4_ADJUST_LIB_VARS(QtCore)
42- set_property(TARGET Qt4::QtCore APPEND PROPERTY
43- INTERFACE_INCLUDE_DIRECTORIES
44- "${QT_MKSPECS_DIR}/default"
45- ${QT_INCLUDE_DIR}
46- )
47- set_property(TARGET Qt4::QtCore APPEND PROPERTY
48- INTERFACE_COMPILE_DEFINITIONS
49- $<$<NOT:$<CONFIG:Debug>>:QT_NO_DEBUG>
50- )
51- set_property(TARGET Qt4::QtCore PROPERTY
52- INTERFACE_QT_MAJOR_VERSION 4
53- )
54- set_property(TARGET Qt4::QtCore APPEND PROPERTY
55- COMPATIBLE_INTERFACE_STRING QT_MAJOR_VERSION
56- )
57+ if(QT_QTCORE_FOUND)
58+ # Set QT_xyz_LIBRARY variable and add
59+ # library include path to QT_INCLUDES
60+ _QT4_ADJUST_LIB_VARS(QtCore)
61+ set_property(TARGET Qt4::QtCore APPEND PROPERTY
62+ INTERFACE_INCLUDE_DIRECTORIES
63+ "${QT_MKSPECS_DIR}/default"
64+ ${QT_INCLUDE_DIR}
65+ )
66+ set_property(TARGET Qt4::QtCore APPEND PROPERTY
67+ INTERFACE_COMPILE_DEFINITIONS
68+ $<$<NOT:$<CONFIG:Debug>>:QT_NO_DEBUG>
69+ )
70+ set_property(TARGET Qt4::QtCore PROPERTY
71+ INTERFACE_QT_MAJOR_VERSION 4
72+ )
73+ set_property(TARGET Qt4::QtCore APPEND PROPERTY
74+ COMPATIBLE_INTERFACE_STRING QT_MAJOR_VERSION
75+ )
76+ endif()
77
78 foreach(QT_MODULE ${QT_MODULES})
79 _QT4_ADJUST_LIB_VARS(${QT_MODULE})