blob: 81e9acd361b5f6ea8470bf520e5cb3623382e052 [file] [log] [blame]
Andrew Geisslerc9f78652020-09-18 14:11:35 -05001From f06c89939d0d006090a8a8728b2a13d532b83047 Mon Sep 17 00:00:00 2001
Brad Bishop316dfdd2018-06-25 12:45:53 -04002From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
3Date: Wed, 15 Nov 2017 15:05:01 +0100
Brad Bishop1a4b7ee2018-12-16 17:11:34 -08004Subject: [PATCH] native_bindir
Brad Bishop316dfdd2018-06-25 12:45:53 -04005
6Some libraries, like QT, have pre-processors that convert their input
7files into something that the cross-compiler can process. We find the
8path of those pre-processors via pkg-config-native instead of
9pkg-config.
10
11This path forces the use of pkg-config-native for host_bins arguments.
12
13There are some discussions upstream to merge this patch, but I presonaly believe
14that is is OE only. https://github.com/mesonbuild/meson/issues/1849#issuecomment-303730323
15
16Upstream-Status: Inappropriate [OE specific]
17Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
18
19---
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080020 mesonbuild/dependencies/base.py | 19 +++++++++++--------
Brad Bishop316dfdd2018-06-25 12:45:53 -040021 mesonbuild/dependencies/ui.py | 6 +++---
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080022 2 files changed, 14 insertions(+), 11 deletions(-)
Brad Bishop316dfdd2018-06-25 12:45:53 -040023
24diff --git a/mesonbuild/dependencies/base.py b/mesonbuild/dependencies/base.py
Andrew Geisslerc9f78652020-09-18 14:11:35 -050025index 368a4bc..9fc398e 100644
Brad Bishop316dfdd2018-06-25 12:45:53 -040026--- a/mesonbuild/dependencies/base.py
27+++ b/mesonbuild/dependencies/base.py
Andrew Geisslerc9f78652020-09-18 14:11:35 -050028@@ -183,7 +183,7 @@ class Dependency:
Brad Bishop08902b02019-08-20 09:16:51 -040029 def get_exe_args(self, compiler):
30 return []
Andrew Geissler82c905d2020-04-13 13:39:40 -050031
Brad Bishop316dfdd2018-06-25 12:45:53 -040032- def get_pkgconfig_variable(self, variable_name, kwargs):
33+ def get_pkgconfig_variable(self, variable_name, kwargs, use_native=False):
34 raise DependencyException('{!r} is not a pkgconfig dependency'.format(self.name))
Andrew Geissler82c905d2020-04-13 13:39:40 -050035
Brad Bishop316dfdd2018-06-25 12:45:53 -040036 def get_configtool_variable(self, variable_name):
Andrew Geisslerc9f78652020-09-18 14:11:35 -050037@@ -261,7 +261,7 @@ class InternalDependency(Dependency):
38 setattr(result, k, copy.deepcopy(v, memo))
39 return result
Andrew Geissler82c905d2020-04-13 13:39:40 -050040
Brad Bishop316dfdd2018-06-25 12:45:53 -040041- def get_pkgconfig_variable(self, variable_name, kwargs):
42+ def get_pkgconfig_variable(self, variable_name, kwargs, use_native=False):
43 raise DependencyException('Method "get_pkgconfig_variable()" is '
44 'invalid for an internal dependency')
Andrew Geissler82c905d2020-04-13 13:39:40 -050045
Andrew Geisslerc9f78652020-09-18 14:11:35 -050046@@ -634,15 +634,18 @@ class PkgConfigDependency(ExternalDependency):
Brad Bishop316dfdd2018-06-25 12:45:53 -040047 return s.format(self.__class__.__name__, self.name, self.is_found,
48 self.version_reqs)
Andrew Geissler82c905d2020-04-13 13:39:40 -050049
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080050- def _call_pkgbin_real(self, args, env):
51- cmd = self.pkgbin.get_command() + args
52+ def _call_pkgbin_real(self, args, env, use_native=False):
53+ if use_native:
Brad Bishopf3fd2882019-06-21 08:06:37 -040054+ cmd = [self.pkgbin.get_command()[0] + "-native"] + args
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080055+ else:
56+ cmd = self.pkgbin.get_command() + args
William A. Kennington IIIc5966302020-03-20 13:04:31 -070057 p, out, err = Popen_safe(cmd, env=env)
58 rc, out, err = p.returncode, out.strip(), err.strip()
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080059 call = ' '.join(cmd)
60 mlog.debug("Called `{}` -> {}\n{}".format(call, rc, out))
William A. Kennington IIIc5966302020-03-20 13:04:31 -070061 return rc, out, err
Andrew Geissler82c905d2020-04-13 13:39:40 -050062
Brad Bishop316dfdd2018-06-25 12:45:53 -040063- def _call_pkgbin(self, args, env=None):
64+ def _call_pkgbin(self, args, env=None, use_native=False):
Brad Bishop08902b02019-08-20 09:16:51 -040065 # Always copy the environment since we're going to modify it
66 # with pkg-config variables
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080067 if env is None:
Andrew Geisslerc9f78652020-09-18 14:11:35 -050068@@ -668,7 +671,7 @@ class PkgConfigDependency(ExternalDependency):
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080069 targs = tuple(args)
70 cache = PkgConfigDependency.pkgbin_cache
71 if (self.pkgbin, targs, fenv) not in cache:
72- cache[(self.pkgbin, targs, fenv)] = self._call_pkgbin_real(args, env)
73+ cache[(self.pkgbin, targs, fenv)] = self._call_pkgbin_real(args, env, use_native)
74 return cache[(self.pkgbin, targs, fenv)]
Andrew Geissler82c905d2020-04-13 13:39:40 -050075
William A. Kennington IIIc5966302020-03-20 13:04:31 -070076 def _convert_mingw_paths(self, args: T.List[str]) -> T.List[str]:
Andrew Geisslerc9f78652020-09-18 14:11:35 -050077@@ -877,7 +880,7 @@ class PkgConfigDependency(ExternalDependency):
William A. Kennington IIIc5966302020-03-20 13:04:31 -070078 (self.name, out_raw))
79 self.link_args, self.raw_link_args = self._search_libs(out, out_raw)
Andrew Geissler82c905d2020-04-13 13:39:40 -050080
Brad Bishop316dfdd2018-06-25 12:45:53 -040081- def get_pkgconfig_variable(self, variable_name, kwargs):
82+ def get_pkgconfig_variable(self, variable_name, kwargs, use_native=False):
83 options = ['--variable=' + variable_name, self.name]
Andrew Geissler82c905d2020-04-13 13:39:40 -050084
Brad Bishop316dfdd2018-06-25 12:45:53 -040085 if 'define_variable' in kwargs:
Andrew Geisslerc9f78652020-09-18 14:11:35 -050086@@ -890,7 +893,7 @@ class PkgConfigDependency(ExternalDependency):
Andrew Geissler82c905d2020-04-13 13:39:40 -050087
Brad Bishop316dfdd2018-06-25 12:45:53 -040088 options = ['--define-variable=' + '='.join(definition)] + options
Andrew Geissler82c905d2020-04-13 13:39:40 -050089
William A. Kennington IIIc5966302020-03-20 13:04:31 -070090- ret, out, err = self._call_pkgbin(options)
91+ ret, out, err = self._call_pkgbin(options, use_native=use_native)
Brad Bishop316dfdd2018-06-25 12:45:53 -040092 variable = ''
93 if ret != 0:
94 if self.required:
95diff --git a/mesonbuild/dependencies/ui.py b/mesonbuild/dependencies/ui.py
Andrew Geisslerc9f78652020-09-18 14:11:35 -050096index 95dfe2b..5f82890 100644
Brad Bishop316dfdd2018-06-25 12:45:53 -040097--- a/mesonbuild/dependencies/ui.py
98+++ b/mesonbuild/dependencies/ui.py
Andrew Geisslerc9f78652020-09-18 14:11:35 -050099@@ -325,7 +325,7 @@ class QtBaseDependency(ExternalDependency):
Brad Bishop316dfdd2018-06-25 12:45:53 -0400100 self.bindir = self.get_pkgconfig_host_bins(core)
101 if not self.bindir:
102 # If exec_prefix is not defined, the pkg-config file is broken
103- prefix = core.get_pkgconfig_variable('exec_prefix', {})
104+ prefix = core.get_pkgconfig_variable('exec_prefix', {}, use_native=True)
105 if prefix:
106 self.bindir = os.path.join(prefix, 'bin')
Andrew Geissler82c905d2020-04-13 13:39:40 -0500107
Andrew Geisslerc9f78652020-09-18 14:11:35 -0500108@@ -528,7 +528,7 @@ class Qt4Dependency(QtBaseDependency):
Brad Bishop316dfdd2018-06-25 12:45:53 -0400109 applications = ['moc', 'uic', 'rcc', 'lupdate', 'lrelease']
110 for application in applications:
111 try:
112- return os.path.dirname(core.get_pkgconfig_variable('%s_location' % application, {}))
113+ return os.path.dirname(core.get_pkgconfig_variable('%s_location' % application, {}, use_native=True))
114 except MesonException:
115 pass
Andrew Geissler82c905d2020-04-13 13:39:40 -0500116
Andrew Geisslerc9f78652020-09-18 14:11:35 -0500117@@ -538,7 +538,7 @@ class Qt5Dependency(QtBaseDependency):
Brad Bishop316dfdd2018-06-25 12:45:53 -0400118 QtBaseDependency.__init__(self, 'qt5', env, kwargs)
Andrew Geissler82c905d2020-04-13 13:39:40 -0500119
Brad Bishop316dfdd2018-06-25 12:45:53 -0400120 def get_pkgconfig_host_bins(self, core):
121- return core.get_pkgconfig_variable('host_bins', {})
122+ return core.get_pkgconfig_variable('host_bins', {}, use_native=True)
Andrew Geissler82c905d2020-04-13 13:39:40 -0500123
Brad Bishop1a4b7ee2018-12-16 17:11:34 -0800124 def get_private_includes(self, mod_inc_dir, module):
125 return _qt_get_private_includes(mod_inc_dir, module, self.version)