blob: 39804bd364ed04e1b6f79f553792d140ebb1c5f5 [file] [log] [blame]
Andrew Geisslerd159c7f2021-09-02 21:05:58 -05001From 45148529792c0cda32fdd61610c8d5a700d541fa Mon Sep 17 00:00:00 2001
Brad Bishop19323692019-04-05 15:28:33 -04002From: Chen Qi <Qi.Chen@windriver.com>
3Date: Tue, 10 Jul 2018 15:40:17 +0800
William A. Kennington IIIac69b482021-06-02 12:28:27 -07004Subject: [PATCH] distinguish XSI-compliant strerror_r from GNU-specifi
Brad Bishop19323692019-04-05 15:28:33 -04005 strerror_r
6
7XSI-compliant strerror_r and GNU-specifi strerror_r are different.
8
9 int strerror_r(int errnum, char *buf, size_t buflen);
10 /* XSI-compliant */
11
12 char *strerror_r(int errnum, char *buf, size_t buflen);
13 /* GNU-specific */
14
15We need to distinguish between them. Otherwise, we'll get an int value
16assigned to (char *) variable, resulting in segment fault.
17
18Upstream-Status: Inappropriate [musl specific]
19
20Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
William A. Kennington IIIac69b482021-06-02 12:28:27 -070021
Brad Bishop19323692019-04-05 15:28:33 -040022---
William A. Kennington IIIac69b482021-06-02 12:28:27 -070023 src/libsystemd/sd-bus/bus-error.c | 5 +++++
24 src/libsystemd/sd-journal/journal-send.c | 5 +++++
Brad Bishop19323692019-04-05 15:28:33 -040025 2 files changed, 10 insertions(+)
26
Andrew Geisslerd1e89492021-02-12 15:35:20 -060027diff --git a/src/libsystemd/sd-bus/bus-error.c b/src/libsystemd/sd-bus/bus-error.c
Andrew Geisslerd159c7f2021-09-02 21:05:58 -050028index 7483b46a11..c49be29e46 100644
Andrew Geisslerd1e89492021-02-12 15:35:20 -060029--- a/src/libsystemd/sd-bus/bus-error.c
30+++ b/src/libsystemd/sd-bus/bus-error.c
Andrew Geisslerd159c7f2021-09-02 21:05:58 -050031@@ -404,7 +404,12 @@ static void bus_error_strerror(sd_bus_error *e, int error) {
Brad Bishop19323692019-04-05 15:28:33 -040032 return;
33
34 errno = 0;
35+#ifndef __GLIBC__
36+ strerror_r(error, m, k);
37+ x = m;
38+#else
39 x = strerror_r(error, m, k);
40+#endif
41 if (errno == ERANGE || strlen(x) >= k - 1) {
42 free(m);
43 k *= 2;
William A. Kennington IIIac69b482021-06-02 12:28:27 -070044diff --git a/src/libsystemd/sd-journal/journal-send.c b/src/libsystemd/sd-journal/journal-send.c
45index e8e6ad555b..8ca5271d02 100644
46--- a/src/libsystemd/sd-journal/journal-send.c
47+++ b/src/libsystemd/sd-journal/journal-send.c
48@@ -348,7 +348,12 @@ static int fill_iovec_perror_and_send(const char *message, int skip, struct iove
49 char* j;
50
51 errno = 0;
52+#ifndef __GLIBC__
53+ strerror_r(_saved_errno_, buffer + 8 + k, n - 8 - k);
54+ j = buffer + 8 + k;
55+#else
56 j = strerror_r(_saved_errno_, buffer + 8 + k, n - 8 - k);
57+#endif
58 if (errno == 0) {
59 char error[STRLEN("ERRNO=") + DECIMAL_STR_MAX(int) + 1];
60