Andrew Geissler | d159c7f | 2021-09-02 21:05:58 -0500 | [diff] [blame^] | 1 | From 0c8935128b39864b07dfee39cfa9d35d48f056aa Mon Sep 17 00:00:00 2001 |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 2 | From: Alex Kiernan <alex.kiernan@gmail.com> |
| 3 | Date: Tue, 10 Mar 2020 11:05:20 +0000 |
William A. Kennington III | ac69b48 | 2021-06-02 12:28:27 -0700 | [diff] [blame] | 4 | Subject: [PATCH] Handle missing gshadow |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 5 | |
| 6 | gshadow usage is now present in the userdb code. Mask all uses of it to |
| 7 | allow compilation on musl |
| 8 | |
| 9 | Upstream-Status: Inappropriate [musl specific] |
| 10 | Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> |
Andrew Geissler | d1e8949 | 2021-02-12 15:35:20 -0600 | [diff] [blame] | 11 | [Rebased for v247] |
| 12 | Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com> |
William A. Kennington III | ac69b48 | 2021-06-02 12:28:27 -0700 | [diff] [blame] | 13 | |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 14 | --- |
Andrew Geissler | d1e8949 | 2021-02-12 15:35:20 -0600 | [diff] [blame] | 15 | src/shared/user-record-nss.c | 20 ++++++++++++++++++++ |
| 16 | src/shared/user-record-nss.h | 4 ++++ |
Andrew Geissler | d159c7f | 2021-09-02 21:05:58 -0500 | [diff] [blame^] | 17 | src/shared/userdb.c | 7 ++++++- |
| 18 | 3 files changed, 30 insertions(+), 1 deletion(-) |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 19 | |
Andrew Geissler | d159c7f | 2021-09-02 21:05:58 -0500 | [diff] [blame^] | 20 | diff --git a/src/shared/user-record-nss.c b/src/shared/user-record-nss.c |
| 21 | index 88b8fc2f8f..a819d41bac 100644 |
Andrew Geissler | d1e8949 | 2021-02-12 15:35:20 -0600 | [diff] [blame] | 22 | --- a/src/shared/user-record-nss.c |
| 23 | +++ b/src/shared/user-record-nss.c |
| 24 | @@ -331,8 +331,10 @@ int nss_group_to_group_record( |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 25 | if (isempty(grp->gr_name)) |
| 26 | return -EINVAL; |
| 27 | |
| 28 | +#if ENABLE_GSHADOW |
| 29 | if (sgrp && !streq_ptr(sgrp->sg_namp, grp->gr_name)) |
| 30 | return -EINVAL; |
| 31 | +#endif |
| 32 | |
| 33 | g = group_record_new(); |
| 34 | if (!g) |
Andrew Geissler | d1e8949 | 2021-02-12 15:35:20 -0600 | [diff] [blame] | 35 | @@ -348,6 +350,7 @@ int nss_group_to_group_record( |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 36 | |
| 37 | g->gid = grp->gr_gid; |
| 38 | |
| 39 | +#if ENABLE_GSHADOW |
| 40 | if (sgrp) { |
Andrew Geissler | d1e8949 | 2021-02-12 15:35:20 -0600 | [diff] [blame] | 41 | if (looks_like_hashed_password(utf8_only(sgrp->sg_passwd))) { |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 42 | g->hashed_password = strv_new(sgrp->sg_passwd); |
Andrew Geissler | d1e8949 | 2021-02-12 15:35:20 -0600 | [diff] [blame] | 43 | @@ -363,6 +366,7 @@ int nss_group_to_group_record( |
| 44 | if (r < 0) |
| 45 | return r; |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 46 | } |
| 47 | +#endif |
| 48 | |
| 49 | r = json_build(&g->json, JSON_BUILD_OBJECT( |
| 50 | JSON_BUILD_PAIR("groupName", JSON_BUILD_STRING(g->group_name)), |
Andrew Geissler | d159c7f | 2021-09-02 21:05:58 -0500 | [diff] [blame^] | 51 | @@ -388,6 +392,7 @@ int nss_sgrp_for_group(const struct group *grp, struct sgrp *ret_sgrp, char **re |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 52 | assert(ret_sgrp); |
| 53 | assert(ret_buffer); |
| 54 | |
| 55 | +#if ENABLE_GSHADOW |
| 56 | for (;;) { |
| 57 | _cleanup_free_ char *buf = NULL; |
| 58 | struct sgrp sgrp, *result; |
Andrew Geissler | d159c7f | 2021-09-02 21:05:58 -0500 | [diff] [blame^] | 59 | @@ -416,6 +421,9 @@ int nss_sgrp_for_group(const struct group *grp, struct sgrp *ret_sgrp, char **re |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 60 | buflen *= 2; |
| 61 | buf = mfree(buf); |
| 62 | } |
| 63 | +#else |
| 64 | + return -ESRCH; |
| 65 | +#endif |
| 66 | } |
| 67 | |
Andrew Geissler | 635e0e4 | 2020-08-21 15:58:33 -0500 | [diff] [blame] | 68 | int nss_group_record_by_name( |
Andrew Geissler | d1e8949 | 2021-02-12 15:35:20 -0600 | [diff] [blame] | 69 | @@ -427,7 +435,9 @@ int nss_group_record_by_name( |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 70 | struct group grp, *result; |
| 71 | bool incomplete = false; |
| 72 | size_t buflen = 4096; |
| 73 | +#if ENABLE_GSHADOW |
Andrew Geissler | 635e0e4 | 2020-08-21 15:58:33 -0500 | [diff] [blame] | 74 | struct sgrp sgrp, *sresult = NULL; |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 75 | +#endif |
| 76 | int r; |
| 77 | |
| 78 | assert(name); |
Andrew Geissler | d1e8949 | 2021-02-12 15:35:20 -0600 | [diff] [blame] | 79 | @@ -457,6 +467,7 @@ int nss_group_record_by_name( |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 80 | buf = mfree(buf); |
| 81 | } |
| 82 | |
| 83 | +#if ENABLE_GSHADOW |
Andrew Geissler | 635e0e4 | 2020-08-21 15:58:33 -0500 | [diff] [blame] | 84 | if (with_shadow) { |
| 85 | r = nss_sgrp_for_group(result, &sgrp, &sbuf); |
| 86 | if (r < 0) { |
Andrew Geissler | d1e8949 | 2021-02-12 15:35:20 -0600 | [diff] [blame] | 87 | @@ -468,6 +479,9 @@ int nss_group_record_by_name( |
Andrew Geissler | 635e0e4 | 2020-08-21 15:58:33 -0500 | [diff] [blame] | 88 | incomplete = true; |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 89 | |
Andrew Geissler | 635e0e4 | 2020-08-21 15:58:33 -0500 | [diff] [blame] | 90 | r = nss_group_to_group_record(result, sresult, ret); |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 91 | +#else |
| 92 | + r = nss_group_to_group_record(result, NULL, ret); |
| 93 | +#endif |
| 94 | if (r < 0) |
| 95 | return r; |
| 96 | |
Andrew Geissler | d1e8949 | 2021-02-12 15:35:20 -0600 | [diff] [blame] | 97 | @@ -484,7 +498,9 @@ int nss_group_record_by_gid( |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 98 | struct group grp, *result; |
| 99 | bool incomplete = false; |
| 100 | size_t buflen = 4096; |
| 101 | +#if ENABLE_GSHADOW |
Andrew Geissler | 635e0e4 | 2020-08-21 15:58:33 -0500 | [diff] [blame] | 102 | struct sgrp sgrp, *sresult = NULL; |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 103 | +#endif |
| 104 | int r; |
| 105 | |
| 106 | assert(ret); |
Andrew Geissler | d1e8949 | 2021-02-12 15:35:20 -0600 | [diff] [blame] | 107 | @@ -512,6 +528,7 @@ int nss_group_record_by_gid( |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 108 | buf = mfree(buf); |
| 109 | } |
| 110 | |
| 111 | +#if ENABLE_GSHADOW |
Andrew Geissler | 635e0e4 | 2020-08-21 15:58:33 -0500 | [diff] [blame] | 112 | if (with_shadow) { |
| 113 | r = nss_sgrp_for_group(result, &sgrp, &sbuf); |
| 114 | if (r < 0) { |
Andrew Geissler | d1e8949 | 2021-02-12 15:35:20 -0600 | [diff] [blame] | 115 | @@ -523,6 +540,9 @@ int nss_group_record_by_gid( |
Andrew Geissler | 635e0e4 | 2020-08-21 15:58:33 -0500 | [diff] [blame] | 116 | incomplete = true; |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 117 | |
Andrew Geissler | 635e0e4 | 2020-08-21 15:58:33 -0500 | [diff] [blame] | 118 | r = nss_group_to_group_record(result, sresult, ret); |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 119 | +#else |
| 120 | + r = nss_group_to_group_record(result, NULL, ret); |
| 121 | +#endif |
| 122 | if (r < 0) |
| 123 | return r; |
| 124 | |
Andrew Geissler | d159c7f | 2021-09-02 21:05:58 -0500 | [diff] [blame^] | 125 | diff --git a/src/shared/user-record-nss.h b/src/shared/user-record-nss.h |
| 126 | index 22ab04d6ee..4e52e7a911 100644 |
Andrew Geissler | d1e8949 | 2021-02-12 15:35:20 -0600 | [diff] [blame] | 127 | --- a/src/shared/user-record-nss.h |
| 128 | +++ b/src/shared/user-record-nss.h |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 129 | @@ -2,7 +2,11 @@ |
| 130 | #pragma once |
| 131 | |
| 132 | #include <grp.h> |
| 133 | +#if ENABLE_GSHADOW |
| 134 | #include <gshadow.h> |
| 135 | +#else |
| 136 | +struct sgrp; |
| 137 | +#endif |
Andrew Geissler | d1e8949 | 2021-02-12 15:35:20 -0600 | [diff] [blame] | 138 | #include <pwd.h> |
| 139 | #include <shadow.h> |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 140 | |
Andrew Geissler | d159c7f | 2021-09-02 21:05:58 -0500 | [diff] [blame^] | 141 | diff --git a/src/shared/userdb.c b/src/shared/userdb.c |
| 142 | index 91ac7c3832..20881ece84 100644 |
Andrew Geissler | c3d88e4 | 2020-10-02 09:45:00 -0500 | [diff] [blame] | 143 | --- a/src/shared/userdb.c |
| 144 | +++ b/src/shared/userdb.c |
Andrew Geissler | d159c7f | 2021-09-02 21:05:58 -0500 | [diff] [blame^] | 145 | @@ -1047,13 +1047,15 @@ int groupdb_iterator_get(UserDBIterator *iterator, GroupRecord **ret) { |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 146 | if (gr) { |
| 147 | _cleanup_free_ char *buffer = NULL; |
| 148 | bool incomplete = false; |
| 149 | +#if ENABLE_GSHADOW |
| 150 | struct sgrp sgrp; |
Patrick Williams | 213cb26 | 2021-08-07 19:21:33 -0500 | [diff] [blame] | 151 | - |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 152 | +#endif |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 153 | if (streq_ptr(gr->gr_name, "root")) |
| 154 | iterator->synthesize_root = false; |
| 155 | if (gr->gr_gid == GID_NOBODY) |
| 156 | iterator->synthesize_nobody = false; |
| 157 | |
| 158 | +#if ENABLE_GSHADOW |
Patrick Williams | 213cb26 | 2021-08-07 19:21:33 -0500 | [diff] [blame] | 159 | if (!FLAGS_SET(iterator->flags, USERDB_SUPPRESS_SHADOW)) { |
William A. Kennington III | ac69b48 | 2021-06-02 12:28:27 -0700 | [diff] [blame] | 160 | r = nss_sgrp_for_group(gr, &sgrp, &buffer); |
| 161 | if (r < 0) { |
Andrew Geissler | d159c7f | 2021-09-02 21:05:58 -0500 | [diff] [blame^] | 162 | @@ -1066,6 +1068,9 @@ int groupdb_iterator_get(UserDBIterator *iterator, GroupRecord **ret) { |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 163 | } |
| 164 | |
| 165 | r = nss_group_to_group_record(gr, r >= 0 ? &sgrp : NULL, ret); |
| 166 | +#else |
| 167 | + r = nss_group_to_group_record(gr, NULL, ret); |
| 168 | +#endif |
| 169 | if (r < 0) |
| 170 | return r; |
| 171 | |