blob: 75c0369318044a91c05179fdb98a923fb5439176 [file] [log] [blame]
Andrew Geisslerd5838332022-05-27 11:33:10 -05001From 375cae3dd6151ef33cae8f243f6a2c2da6c0c356 Mon Sep 17 00:00:00 2001
2From: Richard Purdie <richard.purdie@linuxfoundation.org>
3Date: Fri, 8 Jan 2021 17:27:06 +0000
4Subject: [PATCH 06/12] qemu: Add some user space mmap tweaks to address musl
5 32 bit
6
Andrew Geisslerd1e89492021-02-12 15:35:20 -06007When using qemu-i386 to build qemux86 webkitgtk on musl, it sits in an
8infinite loop of mremap calls of ever decreasing/increasing addresses.
9
10I suspect something in the musl memory allocation code loops indefinitely
11if it only sees ENOMEM and only exits when it hits EFAULT.
12
13According to the docs, trying to mremap outside the address space
14can/should return EFAULT and changing this allows the build to succeed.
Andrew Geisslerd1e89492021-02-12 15:35:20 -060015
Andrew Geissler9b4d8b02021-02-19 12:26:16 -060016A better return value for the other cases of invalid addresses is EINVAL
17rather than ENOMEM so adjust the other part of the test to this.
18
19Upstream-Status: Submitted [https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg01355.html]
Andrew Geisslerd1e89492021-02-12 15:35:20 -060020Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org
21
Andrew Geisslerd5838332022-05-27 11:33:10 -050022---
23 linux-user/mmap.c | 10 +++++++---
24 1 file changed, 7 insertions(+), 3 deletions(-)
25
26diff --git a/linux-user/mmap.c b/linux-user/mmap.c
27index c125031b9..e651834a5 100644
28--- a/linux-user/mmap.c
29+++ b/linux-user/mmap.c
30@@ -749,12 +749,16 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong old_size,
Andrew Geissler9b4d8b02021-02-19 12:26:16 -060031 int prot;
32 void *host_addr;
33
William A. Kennington IIIac69b482021-06-02 12:28:27 -070034- if (!guest_range_valid_untagged(old_addr, old_size) ||
Andrew Geissler9b4d8b02021-02-19 12:26:16 -060035- ((flags & MREMAP_FIXED) &&
William A. Kennington IIIac69b482021-06-02 12:28:27 -070036+ if (!guest_range_valid_untagged(old_addr, old_size)) {
Andrew Geisslerd1e89492021-02-12 15:35:20 -060037+ errno = EFAULT;
Andrew Geissler9b4d8b02021-02-19 12:26:16 -060038+ return -1;
39+ }
William A. Kennington IIIac69b482021-06-02 12:28:27 -070040+
41+ if (((flags & MREMAP_FIXED) &&
42 !guest_range_valid_untagged(new_addr, new_size)) ||
43 ((flags & MREMAP_MAYMOVE) == 0 &&
44 !guest_range_valid_untagged(old_addr, new_size))) {
45- errno = ENOMEM;
Andrew Geissler9b4d8b02021-02-19 12:26:16 -060046+ errno = EINVAL;
Andrew Geisslerd1e89492021-02-12 15:35:20 -060047 return -1;
48 }
49
Andrew Geisslerd5838332022-05-27 11:33:10 -050050--
512.30.2
52