blob: 2f084b4e9b044b363845f3ca589040274266b03a [file] [log] [blame]
Patrick Williamsc124f4f2015-09-15 14:41:29 -05001Upstream-Status: Inappropriate [OE specific]
2
3Subject: useradd.c: create parent directories when necessary
4
5Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
6---
7 src/useradd.c | 72 +++++++++++++++++++++++++++++++++++++++------------------
8 1 file changed, 49 insertions(+), 23 deletions(-)
9
10diff --git a/src/useradd.c b/src/useradd.c
11index 4bd969d..cb5dd6c 100644
12--- a/src/useradd.c
13+++ b/src/useradd.c
Brad Bishop6e60e8b2018-02-01 10:27:11 -050014@@ -1896,6 +1896,35 @@ static void usr_update (void)
Patrick Williamsc124f4f2015-09-15 14:41:29 -050015 }
16
17 /*
18+ * mkdir_p - create directories, including parent directories when needed
19+ *
20+ * similar to `mkdir -p'
21+ */
22+void mkdir_p(const char *path) {
23+ int len = strlen(path);
24+ char newdir[len + 1];
25+ mode_t mode = 0755;
26+ int i = 0;
27+
28+ if (path[i] == '\0') {
29+ return;
30+ }
31+
32+ /* skip the leading '/' */
33+ i++;
34+
35+ while(path[i] != '\0') {
36+ if (path[i] == '/') {
37+ strncpy(newdir, path, i);
38+ newdir[i] = '\0';
39+ mkdir(newdir, mode);
40+ }
41+ i++;
42+ }
43+ mkdir(path, mode);
44+}
45+
46+/*
47 * create_home - create the user's home directory
48 *
49 * create_home() creates the user's home directory if it does not
Brad Bishop6e60e8b2018-02-01 10:27:11 -050050@@ -1910,39 +1939,36 @@ static void create_home (void)
Patrick Williamsc124f4f2015-09-15 14:41:29 -050051 fail_exit (E_HOMEDIR);
52 }
53 #endif
54- /* XXX - create missing parent directories. --marekm */
55- if (mkdir (user_home, 0) != 0) {
56- fprintf (stderr,
57- _("%s: cannot create directory %s\n"),
58- Prog, user_home);
59-#ifdef WITH_AUDIT
60- audit_logger (AUDIT_ADD_USER, Prog,
61- "adding home directory",
62- user_name, (unsigned int) user_id,
63- SHADOW_AUDIT_FAILURE);
64-#endif
65- fail_exit (E_HOMEDIR);
66- }
67- chown (user_home, user_id, user_gid);
68- chmod (user_home,
69- 0777 & ~getdef_num ("UMASK", GETDEF_DEFAULT_UMASK));
Brad Bishop6e60e8b2018-02-01 10:27:11 -050070-#ifdef WITH_ATTR
71- attr_copy_file (def_template, user_home, NULL, NULL);
72-#endif
Patrick Williamsc124f4f2015-09-15 14:41:29 -050073- home_added = true;
74+ mkdir_p(user_home);
75+ }
76+ if (access (user_home, F_OK) != 0) {
77 #ifdef WITH_AUDIT
78 audit_logger (AUDIT_ADD_USER, Prog,
79 "adding home directory",
80 user_name, (unsigned int) user_id,
81- SHADOW_AUDIT_SUCCESS);
82+ SHADOW_AUDIT_FAILURE);
83 #endif
84-#ifdef WITH_SELINUX
85- /* Reset SELinux to create files with default contexts */
86- if (reset_selinux_file_context () != 0) {
87- fail_exit (E_HOMEDIR);
88- }
89+ fail_exit (E_HOMEDIR);
90+ }
91+ chown (user_home, user_id, user_gid);
92+ chmod (user_home,
93+ 0777 & ~getdef_num ("UMASK", GETDEF_DEFAULT_UMASK));
Brad Bishop6e60e8b2018-02-01 10:27:11 -050094+#ifdef WITH_ATTR
95+ attr_copy_file (def_template, user_home, NULL, NULL);
96+#endif
Patrick Williamsc124f4f2015-09-15 14:41:29 -050097+ home_added = true;
98+#ifdef WITH_AUDIT
99+ audit_logger (AUDIT_ADD_USER, Prog,
100+ "adding home directory",
101+ user_name, (unsigned int) user_id,
102+ SHADOW_AUDIT_SUCCESS);
103 #endif
104+#ifdef WITH_SELINUX
105+ /* Reset SELinux to create files with default contexts */
106+ if (reset_selinux_file_context () != 0) {
107+ fail_exit (E_HOMEDIR);
108 }
109+#endif
110 }
111
112 /*
113--
1141.7.9.5
115