fw update: common code
new daemons to implement the flow as described in
https://github.com/openbmc/docs/blob/master/designs/code-update.md
- common/
common code folder
- common update flow
- base class for the device specific update daemons
The new daemons are all following the generic template of Code Updater
daemon as outlined in the design.
The idea is that they are separate daemons (per device, as outlined in
the design) but share all the code that's not device specific.
Tested: next patch in series
Change-Id: If2438b8506aceb8c5313ec13a0bf7cb68f3cc279
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
diff --git a/common/src/software_update.cpp b/common/src/software_update.cpp
new file mode 100644
index 0000000..33bf03b
--- /dev/null
+++ b/common/src/software_update.cpp
@@ -0,0 +1,85 @@
+#include "software_update.hpp"
+
+#include "device.hpp"
+#include "software.hpp"
+
+#include <phosphor-logging/lg2.hpp>
+#include <sdbusplus/async/context.hpp>
+#include <xyz/openbmc_project/Software/Update/aserver.hpp>
+
+SoftwareUpdate::SoftwareUpdate(
+ sdbusplus::async::context& ctx, const char* path, Software& software,
+ const std::set<RequestedApplyTimes>& allowedApplyTimes) :
+ sdbusplus::aserver::xyz::openbmc_project::software::Update<SoftwareUpdate>(
+ ctx, path),
+ software(software), allowedApplyTimes(allowedApplyTimes)
+{}
+
+auto SoftwareUpdate::method_call(start_update_t /*unused*/, auto image,
+ auto applyTime)
+ -> sdbusplus::async::task<start_update_t::return_type>
+{
+ lg2::info("requesting Device update");
+
+ // check if the apply time is allowed by our device
+
+ if (!this->allowedApplyTimes.contains(applyTime))
+ {
+ lg2::error(
+ "the selected apply time {APPLYTIME} is not allowed by the device",
+ "APPLYTIME", applyTime);
+ co_return this->software.getObjectPath();
+ }
+
+ lg2::info("started asynchronous update with fd {FD}", "FD", image.fd);
+
+ Device& device = this->software.getParentDevice();
+
+ int imageDup = dup(image.fd);
+
+ if (imageDup < 0)
+ {
+ lg2::error("ERROR calling dup on fd: {ERR}", "ERR", strerror(errno));
+ co_return this->software.getObjectPath();
+ }
+
+ lg2::debug("starting async update with FD: {FD}\n", "FD", imageDup);
+
+ const std::string newSwid = Software::getRandomSoftwareId(device);
+
+ // Swid = <DeviceX>_<RandomId>
+ // This new swid will then be used for the object path for the new image.
+ std::unique_ptr<Software> softwareUpdate =
+ std::make_unique<Software>(ctx, newSwid, device);
+
+ softwareUpdate->setActivation(ActivationInterface::Activations::NotReady);
+
+ // NOLINTBEGIN
+ ctx.spawn(
+ [](Device& device, int imageDup, RequestedApplyTimes applyTime,
+ std::unique_ptr<Software> swupdate) -> sdbusplus::async::task<> {
+ co_await device.startUpdateAsync(imageDup, applyTime,
+ std::move(swupdate));
+ co_return;
+ }(device, imageDup, applyTime, std::move(softwareUpdate)));
+ // NOLINTEND
+
+ // We need the object path for the new software here.
+ // It must be the same as constructed during the update process.
+ // This is so that bmcweb and redfish clients can keep track of the update
+ // process.
+ co_return Software::getObjPathFromSwid(newSwid);
+}
+
+auto SoftwareUpdate::set_property(allowed_apply_times_t /*unused*/,
+ auto /*unused*/) -> bool
+{
+ // we do not implement this since the allowed apply times are
+ // defined by the device type and cannot be changed via dbus.
+ return false;
+}
+
+auto SoftwareUpdate::get_property(allowed_apply_times_t /*unused*/) const
+{
+ return this->allowedApplyTimes;
+}