Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / 0b1fd51c744a00c287b6999dde096a91906594aa
commit0b1fd51c744a00c287b6999dde096a91906594aa[log] [tgz]
authorzamiseck <zimzam17@gmail.com>Thu Dec 02 10:56:51 2021 -0600
committerAdriana Kobylak <anoo@linux.ibm.com>Thu Mar 10 20:44:16 2022 +0000
treed552b7b51036535c72d2f5f14cb5a59517a0dda6
parent59b640b07148c56e0a344dda198fcac0cd9af836 [diff]
ItemUpdater::erase() : Fixed double delete

In some cases, when the erase function is called, it attempts
to erase an image that is no longer present on the bmc. This
results in the following error "Error deleting image (/xyz/
openbmc_project/software/xxxxxxxx) from image manager: sd_bus_call
noreply: org.freedesktop.DBus.Error.UnknownObject: Unknown object
'/xyz/openbmc_project/software/xxxxxxxx'". This function should
only be attempting to erase images that exist.

Tested:
Case 1: When activating a new image and the process calls the
erase function on its own
Case 2: When calling delete from the BMC command line
Case 3: When calling delete all from the BMC command line

All of the above cases did not throw the aforementioned error

Signed-off-by: Zami Seck <zimzam17@gmail.com>
Change-Id: I66f8734bcaf8cf31f2b009e53c20d59ee26fd5ad
1 file changed
tree: d552b7b51036535c72d2f5f14cb5a59517a0dda6
  1. mmc/
  2. static/
  3. subprojects/
  4. test/
  5. ubi/
  6. usb/
  7. xyz/
  8. .clang-format
  9. .gitignore
  10. activation.cpp
  11. activation.hpp
  12. download_manager.cpp
  13. download_manager.hpp
  14. download_manager_main.cpp
  15. elog-errors.hpp
  16. flash.hpp
  17. force-reboot.service.in
  18. gen-bios-tar
  19. image_manager.cpp
  20. image_manager.hpp
  21. image_manager_main.cpp
  22. image_verify.cpp
  23. image_verify.hpp
  24. images.cpp
  25. images.hpp
  26. item_updater.cpp
  27. item_updater.hpp
  28. item_updater_helper.hpp
  29. item_updater_main.cpp
  30. LICENSE
  31. MAINTAINERS
  32. meson.build
  33. meson_options.txt
  34. msl_verify.cpp
  35. msl_verify.hpp
  36. obmc-flash-bmc
  37. obmc-flash-bmc-setenv@.service.in
  38. obmc-flash-host-bios@.service.in
  39. openssl_alloc.cpp
  40. openssl_alloc.hpp
  41. OWNERS
  42. README.md
  43. reboot-guard-disable.service.in
  44. reboot-guard-enable.service.in
  45. serialize.cpp
  46. serialize.hpp
  47. software.conf
  48. sync_manager.cpp
  49. sync_manager.hpp
  50. sync_manager_main.cpp
  51. sync_watch.cpp
  52. sync_watch.hpp
  53. synclist
  54. usr-local.mount.in
  55. utils.cpp
  56. utils.hpp
  57. version.cpp
  58. version.hpp
  59. watch.cpp
  60. watch.hpp
  61. xyz.openbmc_project.Software.BMC.Updater.service.in
  62. xyz.openbmc_project.Software.Download.service.in
  63. xyz.openbmc_project.Software.Sync.service.in
  64. xyz.openbmc_project.Software.Version.service.in
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

  1. meson build
  2. ninja -C build

To clean the repository run rm -r build.