Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / 292159f41692367c2ea77b260fdc51283f61193c
commit292159f41692367c2ea77b260fdc51283f61193c[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Tue May 05 09:25:55 2020 -0500
committerAdriana Kobylak <anoo@us.ibm.com>Fri May 22 08:09:19 2020 -0500
tree3be516eb64507192d84ba52b2738bd5ed72c9d25
parent97d4546d3172609b51cad86bb4edbf75de56dff0 [diff]
meson: Fix compile errors

Meson runs stricter compiler checks. Fix the following errors in
preparation to moving to meson:

- Unusued parameters. Ex:
../download_manager_main.cpp:7:14: error: unused parameter ‘argc’ [-Werror=unused-parameter]
../static/item_updater_helper.cpp:16:42: error: unused parameter ‘entryId’ [-Werror=unused-parameter]
../watch.cpp:77:38: error: unused parameter ‘s’ [-Werror=unused-parameter]
[test/utest.cpp:166]: (style) Variable 'pubKeyConfFile' is assigned a value that is never used.

- Add destructor and initialize variable in init list:
../flash.hpp:18:7: error: ‘class phosphor::software::updater::Flash’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]
[version.hpp:81]: callback is assigned in constructor body. Consider performing initialization in initialization list

Tested: Verified code update on witherspoon still worked.

Change-Id: Ib7a0e0e11d6bfe6eeeb3f2ea4bfefd43505d639e
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
10 files changed
tree: 3be516eb64507192d84ba52b2738bd5ed72c9d25
  1. static/
  2. test/
  3. ubi/
  4. xyz/
  5. .clang-format
  6. .gitignore
  7. activation.cpp
  8. activation.hpp
  9. bootstrap.sh
  10. configure.ac
  11. download_manager.cpp
  12. download_manager.hpp
  13. download_manager_main.cpp
  14. elog-errors.hpp
  15. flash.hpp
  16. gen-bios-tar
  17. image_manager.cpp
  18. image_manager.hpp
  19. image_manager_main.cpp
  20. image_verify.cpp
  21. image_verify.hpp
  22. images.hpp
  23. item_updater.cpp
  24. item_updater.hpp
  25. item_updater_helper.hpp
  26. item_updater_main.cpp
  27. LICENSE
  28. MAINTAINERS
  29. Makefile.am
  30. obmc-flash-bmc
  31. obmc-flash-bmc-setenv@.service
  32. obmc-flash-host-bios@.service
  33. openssl_alloc.cpp
  34. openssl_alloc.hpp
  35. README.md
  36. serialize.cpp
  37. serialize.hpp
  38. software.conf
  39. sync_manager.cpp
  40. sync_manager.hpp
  41. sync_manager_main.cpp
  42. sync_watch.cpp
  43. sync_watch.hpp
  44. synclist
  45. usr-local.mount
  46. utils.cpp
  47. utils.hpp
  48. version.cpp
  49. version.hpp
  50. watch.cpp
  51. watch.hpp
  52. xyz.openbmc_project.Software.BMC.Updater.service
  53. xyz.openbmc_project.Software.Download.service
  54. xyz.openbmc_project.Software.Sync.service
  55. xyz.openbmc_project.Software.Version.service
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.