Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / f2b5e0dff4db4707c050247e07ed57819a27c187
commitf2b5e0dff4db4707c050247e07ed57819a27c187[log] [tgz]
authorMichael Tritz <mtritz@us.ibm.com>Tue Jul 25 14:39:34 2017 -0500
committerPatrick Williams <patrick@stwcx.xyz>Tue Aug 01 12:54:00 2017 +0000
tree5297e36672f69767817ea9e925b1f5088f14c3a2
parent3526ef73a955ef206bee0d82b99cca6cb4907759 [diff]
Miscellaneous improvements to activation/item updater

This commit slightly enhances and improves the item updater and the
activation process, addressing a few issues that were raised in code
review of openbmc/openbmc#1756

1.) Service file booleans used in activation are reset to false, to
avoid a BMC-flavored issue in the vein of openbmc/openbmc#1984

2.) systemd constants used in multiple places are moved to configure.ac

3.) Activation objects are unsubscribed from systemd signals at the end
of that process.

Resolves openbmc/openbmc#2031

Change-Id: I573645b16bca28ac6bf3b173d5b4845205224e07
Signed-off-by: Michael Tritz <mtritz@us.ibm.com>
4 files changed
tree: 5297e36672f69767817ea9e925b1f5088f14c3a2
  1. test/
  2. xyz/
  3. .gitignore
  4. activation.cpp
  5. activation.hpp
  6. bootstrap.sh
  7. configure.ac
  8. download_manager.cpp
  9. download_manager.hpp
  10. download_manager_main.cpp
  11. elog-errors.hpp
  12. image_manager.cpp
  13. image_manager.hpp
  14. image_manager_main.cpp
  15. item_updater.cpp
  16. item_updater.hpp
  17. item_updater_main.cpp
  18. LICENSE
  19. Makefile.am
  20. README.md
  21. version.cpp
  22. version.hpp
  23. watch.cpp
  24. watch.hpp
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To full clean the repository again run `./bootstrap.sh clean`.