commit 2d5704e62bd2f3216a8aa6f0be4daefaf0274435
author Pavithra Barithaya <pavithrabarithaya07@gmail.com> Wed Jun 26 02:35:08 2024 -0500
committer Pavithra Barithaya <pavithrabarithaya07@gmail.com> Wed Jul 10 05:55:20 2024 +0000
tree e6fa17960735a5ea6f50c6c8740bfb84d640cf94
parent 9d7b3314014cac547d08a5f54ef5b2f00e3cc20f

clang-tidy: Enable readability-simplify-boolean-expr check

This check looks for boolean expressions involving boolean
constants and simplifies them to use the appropriate boolean
expression directly.

Change-Id: I79d7e4486bd0ea5f5b9b5a1644af99384e41e251
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

msl_verify.cpp

diff --git a/msl_verify.cpp b/msl_verify.cpp
index cf05ea3..d578281 100644
--- a/msl_verify.cpp
+++ b/msl_verify.cpp
@@ -120,11 +120,7 @@
 {
     std::string msl = getMinimumVersion();
     std::string mslRegex{REGEX_BMC_MSL};
-    if (!msl.empty() && !mslRegex.empty())
-    {
-        return true;
-    }
-    return false;
+    return !msl.empty() && !mslRegex.empty();
 }
 
 std::string minimum_ship_level::getMinimumVersion()