| commit | 43c1409112a41b5e150871fdeb2cae3bbce4e629 | [log] [tgz] |
|---|---|---|
| author | Patrick Williams <patrick@stwcx.xyz> | Sat Apr 19 12:39:38 2025 -0400 |
| committer | Patrick Williams <patrick@stwcx.xyz> | Mon Apr 21 11:03:18 2025 -0400 |
| tree | 606253f82db73eb2a2f3957e086e71c858a478f2 | |
| parent | 521b93c373320a60ebbd845261934b207dc93846 [diff] |
phosphor-bios-software-update: move to libexec Non-user executables are suppose to be installed into libexec[1]. [1]: https://github.com/openbmc/docs/blob/master/anti-patterns.md#incorrect-placement-of-executables-in-sbin-usrsbin-or-bin-usrbin Tested: ``` $ meson install -C builddir --destdir /tmp/phosphor-bmc-code-mgmt $ find /tmp/phosphor-bmc-code-mgmt/ -name phosphor-bios-software-update /tmp/phosphor-bmc-code-mgmt/usr/local/libexec/phosphor-bmc-code-mgmt/phosphor-bios-software-update ``` Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ib0b6da9218dc0ebd67077c8cf0e5e8bb6b64d11b
diff --git a/bios/meson.build b/bios/meson.build index 358e5d8..8e0092a 100644 --- a/bios/meson.build +++ b/bios/meson.build
@@ -19,6 +19,7 @@ ], link_with: [libpldmutil, software_common_lib], install: true, + install_dir: get_option('libexecdir') / 'phosphor-code-mgmt', ) systemd_system_unit_dir = dependency('systemd').get_variable(
diff --git a/bios/xyz.openbmc_project.Software.BIOS.service b/bios/xyz.openbmc_project.Software.BIOS.service index e57fd55..524acab 100644 --- a/bios/xyz.openbmc_project.Software.BIOS.service +++ b/bios/xyz.openbmc_project.Software.BIOS.service
@@ -9,7 +9,7 @@ Restart=always Type=oneshot RemainAfterExit=no -ExecStart=/usr/bin/phosphor-bios-software-update +ExecStart=/usr/libexec/phosphor-code-mgmt/phosphor-bios-software-update [Install] WantedBy=multi-user.target