Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / 447d0daa6ed1855a9fcd077f17665ff8d9683db3
commit447d0daa6ed1855a9fcd077f17665ff8d9683db3[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Mon Mar 15 13:40:52 2021 -0500
committerAdriana Kobylak <anoo@us.ibm.com>Tue Mar 16 14:50:19 2021 +0000
tree77c3419b95f06607ecfd562b040ac10131f8022f
parent1fd6dddf7d8203b04a0ff9878f74bc07ffdc0a1e [diff]
image_manager: Create error on machine mismatch

Currently the image manager only logs a journal entry if the machine
does not match. Create an error log so that it is easier to the user to
determine what the error is since an error log is exposed via REST and
the web interface. Use the existing ImageFailure error, as it seems
relevant to the machine not matching.

Tested: Verified a new ImageFailure error was created:
$ curl -k -H "X-Auth-Token: $token" \
https://${bmc}/xyz/openbmc_project/logging/entry/2
{
  "data": {
    "AdditionalData": [
      "FAIL=Machine name does not match",
      "PATH=/tmp/images/imageL4OiKL/MANIFEST",
      "_PID=487"
    ],
    "Message": "xyz.openbmc_project.Software.Image.Error.ImageFailure",

$ curl -k -H "X-Auth-Token: $token"
https://${bmc}/xyz/openbmc_project/logging/entry/4
{
  "data": {
    "AdditionalData": [
      "FAIL=MANIFEST is missing machine name",
      "PATH=/tmp/images/imageqwT1cj/MANIFEST",
      "_PID=477"
    ],
    "Message": "xyz.openbmc_project.Software.Image.Error.ImageFailure",

Change-Id: Ie6681acea51e328c4bfe5bbd3af9aff32e8e539d
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
1 file changed
tree: 77c3419b95f06607ecfd562b040ac10131f8022f
  1. mmc/
  2. static/
  3. test/
  4. ubi/
  5. xyz/
  6. .clang-format
  7. .gitignore
  8. activation.cpp
  9. activation.hpp
  10. download_manager.cpp
  11. download_manager.hpp
  12. download_manager_main.cpp
  13. elog-errors.hpp
  14. flash.hpp
  15. force-reboot.service.in
  16. gen-bios-tar
  17. image_manager.cpp
  18. image_manager.hpp
  19. image_manager_main.cpp
  20. image_verify.cpp
  21. image_verify.hpp
  22. images.cpp
  23. images.hpp
  24. item_updater.cpp
  25. item_updater.hpp
  26. item_updater_helper.hpp
  27. item_updater_main.cpp
  28. LICENSE
  29. MAINTAINERS
  30. meson.build
  31. meson_options.txt
  32. msl_verify.cpp
  33. msl_verify.hpp
  34. obmc-flash-bmc
  35. obmc-flash-bmc-setenv@.service.in
  36. obmc-flash-host-bios@.service.in
  37. openssl_alloc.cpp
  38. openssl_alloc.hpp
  39. README.md
  40. reboot-guard-disable.service.in
  41. reboot-guard-enable.service.in
  42. serialize.cpp
  43. serialize.hpp
  44. software.conf
  45. sync_manager.cpp
  46. sync_manager.hpp
  47. sync_manager_main.cpp
  48. sync_watch.cpp
  49. sync_watch.hpp
  50. synclist
  51. usr-local.mount.in
  52. utils.cpp
  53. utils.hpp
  54. version.cpp
  55. version.hpp
  56. watch.cpp
  57. watch.hpp
  58. xyz.openbmc_project.Software.BMC.Updater.service.in
  59. xyz.openbmc_project.Software.Download.service.in
  60. xyz.openbmc_project.Software.Sync.service.in
  61. xyz.openbmc_project.Software.Version.service.in
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

  1. meson build
  2. ninja -C build

To clean the repository run rm -r build.