Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / 8bd84c8b24a425cf16eb593d8b245b2b8ed11b5f
commit8bd84c8b24a425cf16eb593d8b245b2b8ed11b5f[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Wed Jan 24 14:19:24 2018 -0600
committerAdriana Kobylak <anoo@us.ibm.com>Wed Jan 24 14:37:50 2018 -0600
tree4dbf372cd2d3e5c292c9812ebceeb128ba17db44
parent00bd9029eb06acf34d446c17db4af27a07c52fe0 [diff]
Avoid calling Activation repeatedly during update

The Activation code monitors the systemd service files that
create the volumes, and sets the value to Activating if the
services are running, or Failed if they fail.

This monitoring code checks the name of the service file for
when it fails, but it wasn't checking it for when it succeeds,
leading to any systemd file that finished to trigger calling
the Activation function multiple times.

Also avoid removing the Priority object if the requested
Activation value is Activating, since that's what the value
the monitoring code calls during the update.

Part of openbmc/openbmc#2764

Change-Id: Ib6681ce5d63d184a2ee9ffe05c083e1085efd2ac
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
1 file changed
tree: 4dbf372cd2d3e5c292c9812ebceeb128ba17db44
  1. org/
  2. test/
  3. xyz/
  4. .gitignore
  5. activation.cpp
  6. activation.hpp
  7. bootstrap.sh
  8. configure.ac
  9. download_manager.cpp
  10. download_manager.hpp
  11. download_manager_main.cpp
  12. elog-errors.hpp
  13. image_manager.cpp
  14. image_manager.hpp
  15. image_manager_main.cpp
  16. item_updater.cpp
  17. item_updater.hpp
  18. item_updater_main.cpp
  19. LICENSE
  20. Makefile.am
  21. README.md
  22. serialize.cpp
  23. serialize.hpp
  24. version.cpp
  25. version.hpp
  26. watch.cpp
  27. watch.hpp
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To full clean the repository again run `./bootstrap.sh clean`.