| commit | 4fef1c451e2c2f4ce732660669ddd783cadc56c3 | [log] [tgz] |
|---|---|---|
| author | Patrick Williams <patrick@stwcx.xyz> | Sat Apr 19 12:39:38 2025 -0400 |
| committer | Patrick Williams <patrick@stwcx.xyz> | Mon Apr 21 11:02:39 2025 -0400 |
| tree | eb5c0dd098f205942323ac15c5f677896d4cf578 | |
| parent | 4c5cb936ae27d5b499e1919db20a88f804759192 [diff] |
phosphor-version-software-manager: move to libexec Non-user executables are suppose to be installed into libexec[1]. [1]: https://github.com/openbmc/docs/blob/master/anti-patterns.md#incorrect-placement-of-executables-in-sbin-usrsbin-or-bin-usrbin Tested: ``` $ meson install -C builddir --destdir /tmp/phosphor-bmc-code-mgmt $ find /tmp/phosphor-bmc-code-mgmt/ -name phosphor-version-software-manager /tmp/phosphor-bmc-code-mgmt/usr/local/libexec/phosphor-bmc-code-mgmt/phosphor-version-software-manager ``` Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I89254e142fdaa4eff55ded4d052eae0399c2306b
diff --git a/bmc/meson.build b/bmc/meson.build index 7909c58..28caf18 100644 --- a/bmc/meson.build +++ b/bmc/meson.build
@@ -230,6 +230,7 @@ software_common_sources, dependencies: [deps, ssl], install: true, + install_dir: get_option('libexecdir') / 'phosphor-code-mgmt', ) install_data(
diff --git a/bmc/xyz.openbmc_project.Software.Version.service.in b/bmc/xyz.openbmc_project.Software.Version.service.in index 9651ee2..36b21db 100644 --- a/bmc/xyz.openbmc_project.Software.Version.service.in +++ b/bmc/xyz.openbmc_project.Software.Version.service.in
@@ -3,7 +3,7 @@ [Service] ExecStartPre=/bin/sh -c 'mkdir -p /tmp/images' -ExecStart=/usr/bin/phosphor-version-software-manager +ExecStart=/usr/libexec/phosphor-code-mgmt/phosphor-version-software-manager Restart=always Type=dbus BusName={BUSNAME}