Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / 60f5ccfd5ab0fc8cedc3a2bf5f5adcab77318b7d
commit60f5ccfd5ab0fc8cedc3a2bf5f5adcab77318b7d[log] [tgz]
authorGunnar Mills <gmills@us.ibm.com>Thu May 28 12:26:39 2020 -0500
committerGunnar Mills <gmills@us.ibm.com>Mon Jun 01 12:12:22 2020 -0500
treeb245d262de74799f7af3b3903ac61be996382e03
parentc98d912ec7de0b0d8bd7ad5d47539c858582ea0f [diff]
Factory Reset: Wait for env variables

A call to FactoryReset followed by an immediate reboot does not work.
Add a 3 second sleep to allow the env variables to complete.
This sleep is already in IPMI and was going to be added to
bmcweb as part of Redfish Factory Reset support, instead add here
and remove from IPMI.
https://github.com/openbmc/openpower-host-ipmi-oem/blob/61950109c770fc65f7b5539974487a5a05c54bb5/oemhandler.cpp#L355

There's still a chance 3 secs is not enough if the BMC CPU usage is
high and processes are running slow, but should be very uncommon.

Could subscribe to systemd signals but this adds more complexity and
in the past, phosphor-bmc-code-mgmt had problems with this on the
Priority value. This is probably the best solution for now.

Tested: Redfish factory reset works.
Change-Id: Ibd9c5ca87e8fcd80b558ec4e6a9486efef19421b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
1 file changed
tree: b245d262de74799f7af3b3903ac61be996382e03
  1. static/
  2. test/
  3. ubi/
  4. xyz/
  5. .clang-format
  6. .gitignore
  7. activation.cpp
  8. activation.hpp
  9. bootstrap.sh
  10. configure.ac
  11. download_manager.cpp
  12. download_manager.hpp
  13. download_manager_main.cpp
  14. elog-errors.hpp
  15. flash.hpp
  16. force-reboot.service
  17. gen-bios-tar
  18. image_manager.cpp
  19. image_manager.hpp
  20. image_manager_main.cpp
  21. image_verify.cpp
  22. image_verify.hpp
  23. images.hpp
  24. item_updater.cpp
  25. item_updater.hpp
  26. item_updater_helper.hpp
  27. item_updater_main.cpp
  28. LICENSE
  29. MAINTAINERS
  30. Makefile.am
  31. obmc-flash-bmc
  32. obmc-flash-bmc-setenv@.service
  33. obmc-flash-host-bios@.service
  34. openssl_alloc.cpp
  35. openssl_alloc.hpp
  36. README.md
  37. reboot-guard-disable.service
  38. reboot-guard-enable.service
  39. serialize.cpp
  40. serialize.hpp
  41. software.conf
  42. sync_manager.cpp
  43. sync_manager.hpp
  44. sync_manager_main.cpp
  45. sync_watch.cpp
  46. sync_watch.hpp
  47. synclist
  48. usr-local.mount
  49. utils.cpp
  50. utils.hpp
  51. version.cpp
  52. version.hpp
  53. watch.cpp
  54. watch.hpp
  55. xyz.openbmc_project.Software.BMC.Updater.service
  56. xyz.openbmc_project.Software.Download.service
  57. xyz.openbmc_project.Software.Sync.service
  58. xyz.openbmc_project.Software.Version.service
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.