commit 6d17852d7f126392c9ad67fd703de783f65770d1
author Pavithra Barithaya <pavithrabarithaya07@gmail.com> Mon Jun 24 04:17:29 2024 -0500
committer Pavithra Barithaya <pavithrabarithaya07@gmail.com> Wed Jul 10 04:37:36 2024 +0000
tree f1d343f732f023ce62dde6d5d20a51aa738c673a
parent d1c86585bb3080f0efd4a45d110bf4b2e235a585

clang-tidy: Enable performance-unnecessary-value-param check

This check flags value parameter declarations of expensive to copy
types that are copied for each invocation but it would suffice to
pass them by const reference.

Change-Id: I631deda63fcbb74362313c9596bf7e72933b0d0c
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

item_updater.hpp

diff --git a/item_updater.hpp b/item_updater.hpp
index 59f9839..a0607fe 100644
--- a/item_updater.hpp
+++ b/item_updater.hpp
@@ -275,7 +275,7 @@
      *
      * @param[in]  versionId - The version id.
      */
-    void removeReadOnlyPartition(std::string versionId);
+    void removeReadOnlyPartition(const std::string& versionId);
 
     /** @brief Copies U-Boot from the currently booted BMC chip to the
      *  alternate chip.