commit 6d17852d7f126392c9ad67fd703de783f65770d1
author Pavithra Barithaya <pavithrabarithaya07@gmail.com> Mon Jun 24 04:17:29 2024 -0500
committer Pavithra Barithaya <pavithrabarithaya07@gmail.com> Wed Jul 10 04:37:36 2024 +0000
tree f1d343f732f023ce62dde6d5d20a51aa738c673a
parent d1c86585bb3080f0efd4a45d110bf4b2e235a585

clang-tidy: Enable performance-unnecessary-value-param check

This check flags value parameter declarations of expensive to copy
types that are copied for each invocation but it would suffice to
pass them by const reference.

Change-Id: I631deda63fcbb74362313c9596bf7e72933b0d0c
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

version.hpp

diff --git a/version.hpp b/version.hpp
index 8a85ba9..77b20f7 100644
--- a/version.hpp
+++ b/version.hpp
@@ -87,7 +87,7 @@
             const std::string& id) :
         VersionInherit(bus, (objPath).c_str(),
                        VersionInherit::action::defer_emit),
-        eraseCallback(callback), id(id), versionStr(versionString)
+        eraseCallback(std::move(callback)), id(id), versionStr(versionString)
     {
         // Set properties.
         extendedVersion(extVersion);