| commit | 7292aeca7f15f140d6cf596ac5593d684bef2be8 | [log] [tgz] |
|---|---|---|
| author | Patrick Williams <patrick@stwcx.xyz> | Sat Apr 19 12:39:38 2025 -0400 |
| committer | Patrick Williams <patrick@stwcx.xyz> | Mon Apr 21 11:01:58 2025 -0400 |
| tree | acae932869160aa8295856a516b8ea269ffdff70 | |
| parent | 089a4a34914e0fcfd2b0690c5476c35d4672faaf [diff] |
phosphor-download-manager: move to libexec Non-user executables are suppose to be installed into libexec[1]. [1]: https://github.com/openbmc/docs/blob/master/anti-patterns.md#incorrect-placement-of-executables-in-sbin-usrsbin-or-bin-usrbin Tested: ``` $ meson install -C builddir --destdir /tmp/phosphor-bmc-code-mgmt $ find /tmp/phosphor-bmc-code-mgmt/ -name phosphor-download-manager /tmp/phosphor-bmc-code-mgmt/usr/local/libexec/phosphor-bmc-code-mgmt/phosphor-download-manager ``` Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: If56d9639c20b00c8249d086af82bb62fb13ded66
diff --git a/bmc/meson.build b/bmc/meson.build index abe18fb..930bd0c 100644 --- a/bmc/meson.build +++ b/bmc/meson.build
@@ -188,6 +188,7 @@ 'download_manager_main.cpp', dependencies: deps, install: true, + install_dir: get_option('libexecdir') / 'phosphor-code-mgmt', ) software_common_sources = files('software_utils.cpp')
diff --git a/bmc/xyz.openbmc_project.Software.Download.service.in b/bmc/xyz.openbmc_project.Software.Download.service.in index 404691e..e6fa07f 100644 --- a/bmc/xyz.openbmc_project.Software.Download.service.in +++ b/bmc/xyz.openbmc_project.Software.Download.service.in
@@ -2,7 +2,7 @@ Description=Phosphor Download Manager [Service] -ExecStart=/usr/bin/phosphor-download-manager +ExecStart=/usr/libexec/phosphor-code-mgmt/phosphor-download-manager Restart=always Type=dbus BusName={BUSNAME}