Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / 0f88b5afec39b0fcb31cb5b9692599305cca4c24
commit0f88b5afec39b0fcb31cb5b9692599305cca4c24[log] [tgz]
authorLei YU <mine260309@gmail.com>Tue Aug 21 15:28:53 2018 +0800
committerLei YU <mine260309@gmail.com>Thu Aug 30 03:03:05 2018 +0000
treee1f350ffb64c92979cfd91cc15e725e0d9d859d8
parent269bff30da8dfabe84d29d6a510bf3b5fdb51fee [diff]
Delete functional BMC id if ACTIVE_BMC_MAX_ALLOWED is less than 2

The current logic in ItemUpdater::freeSpace() will try to find the
non-functional BMC ids and remove extra ones as long as the active BMC
images is greater than ACTIVE_BMC_MAX_ALLOWED.

For static layout systems with only one BMC flash chip, the above logic
will cause an issue that the "old" BMC id not deleted during code
update, because the "old" BMC id is the functional one.

This commit changes the above logic, that if ACTIVE_BMC_MAX_ALLOWED is
less than 2 (e.g. 1), delete the functional BMC id as well, because
there really is only one BMC after all.

Partly resolves openbmc/phosphor-bmc-code-mgmt#2

Tested: Verify that the "old" BMC id is deleted during code update, if
        ACTIVE_BMC_MAX_ALLOWED is configured to 1, on Romulus.

Change-Id: I6f21b4269dd78d71f7e9181bb913c49b575321d1
Signed-off-by: Lei YU <mine260309@gmail.com>
1 file changed
tree: e1f350ffb64c92979cfd91cc15e725e0d9d859d8
  1. org/
  2. static/
  3. test/
  4. ubi/
  5. xyz/
  6. .clang-format
  7. .gitignore
  8. activation.cpp
  9. activation.hpp
  10. bootstrap.sh
  11. configure.ac
  12. download_manager.cpp
  13. download_manager.hpp
  14. download_manager_main.cpp
  15. elog-errors.hpp
  16. flash.hpp
  17. image_manager.cpp
  18. image_manager.hpp
  19. image_manager_main.cpp
  20. image_verify.cpp
  21. image_verify.hpp
  22. images.hpp
  23. item_updater.cpp
  24. item_updater.hpp
  25. item_updater_helper.hpp
  26. item_updater_main.cpp
  27. LICENSE
  28. MAINTAINERS
  29. Makefile.am
  30. README.md
  31. serialize.cpp
  32. serialize.hpp
  33. sync_manager.cpp
  34. sync_manager.hpp
  35. sync_manager_main.cpp
  36. sync_watch.cpp
  37. sync_watch.hpp
  38. version.cpp
  39. version.hpp
  40. watch.cpp
  41. watch.hpp
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.