| commit | 781de31ee4333abc7505414d96632a5af4afcf44 | [log] [tgz] |
|---|---|---|
| author | Patrick Williams <patrick@stwcx.xyz> | Sat Apr 19 12:39:38 2025 -0400 |
| committer | Patrick Williams <patrick@stwcx.xyz> | Mon Apr 21 11:03:28 2025 -0400 |
| tree | 9b69776dca24f588f59ca0bf6193431a06e31bc0 | |
| parent | 43c1409112a41b5e150871fdeb2cae3bbce4e629 [diff] |
phosphor-i2cvr-software-update: move to libexec Non-user executables are suppose to be installed into libexec[1]. [1]: https://github.com/openbmc/docs/blob/master/anti-patterns.md#incorrect-placement-of-executables-in-sbin-usrsbin-or-bin-usrbin Tested: ``` $ meson install -C builddir --destdir /tmp/phosphor-bmc-code-mgmt $ find /tmp/phosphor-bmc-code-mgmt/ -name phosphor-i2cvr-software-update /tmp/phosphor-bmc-code-mgmt/usr/local/libexec/phosphor-bmc-code-mgmt/phosphor-i2cvr-software-update ``` Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I87fded12f5bafd5deb5b130f6f0350d67ce401b3
diff --git a/i2c-vr/meson.build b/i2c-vr/meson.build index 001fcf4..9a6a812 100644 --- a/i2c-vr/meson.build +++ b/i2c-vr/meson.build
@@ -19,6 +19,7 @@ ], link_with: [software_common_lib, libpldmutil], install: true, + install_dir: get_option('libexecdir') / 'phosphor-code-mgmt', ) systemd_system_unit_dir = dependency('systemd').get_variable(
diff --git a/i2c-vr/xyz.openbmc_project.Software.I2CVR.service b/i2c-vr/xyz.openbmc_project.Software.I2CVR.service index 6d129ad..e36111b 100644 --- a/i2c-vr/xyz.openbmc_project.Software.I2CVR.service +++ b/i2c-vr/xyz.openbmc_project.Software.I2CVR.service
@@ -7,7 +7,7 @@ Restart=always Type=exec RemainAfterExit=no -ExecStart=/usr/bin/phosphor-i2cvr-software-update +ExecStart=/usr/libexec/phosphor-code-mgmt/phosphor-i2cvr-software-update [Install] WantedBy=multi-user.target