Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / 56ec62e25a5279ee7942a472e4fc9427c403688a
commit56ec62e25a5279ee7942a472e4fc9427c403688a[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Wed Jan 20 10:57:18 2021 -0600
committerAdriana Kobylak <anoo@us.ibm.com>Wed Jan 27 15:54:47 2021 -0600
treedf85ed4f7ed0f11d2b3f6563cc35bb9e0ce7c494
parent8a5ccbb517cf877852caae3acf07fd43586f9a8f [diff]
reset: Call execute() instead of systemd service

The obmc-flash-bmc-setenv@.service file calls a script that
runs the fw_setenv command. Call the fw_setenv command directly
as an effort to move away from systemd service calls which are
async calls and are harder to monitor for completion.

The only difference is that the script calls fw_setenv twice
because for certain variables such as field mode, the code
parses the actual environment file to get the value, and if
the system supports a redundant environment, then fw_setenv
is needed to be called twice so that the updated value is
reflected in both redundant copies and the code parses the
value correctly.

Factory reset is not a value that is parsed by this code,
so a single call is enough.

Tested: Verified in witherspoon that the rwreset environment
        variable was set and factory reset occurred upon reboot.

Change-Id: I76691b1c8c78aa9232074d10d435a3e944b1cd9a
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
2 files changed
tree: df85ed4f7ed0f11d2b3f6563cc35bb9e0ce7c494
  1. mmc/
  2. static/
  3. test/
  4. ubi/
  5. xyz/
  6. .clang-format
  7. .gitignore
  8. activation.cpp
  9. activation.hpp
  10. download_manager.cpp
  11. download_manager.hpp
  12. download_manager_main.cpp
  13. elog-errors.hpp
  14. flash.hpp
  15. force-reboot.service.in
  16. gen-bios-tar
  17. image_manager.cpp
  18. image_manager.hpp
  19. image_manager_main.cpp
  20. image_verify.cpp
  21. image_verify.hpp
  22. images.cpp
  23. images.hpp
  24. item_updater.cpp
  25. item_updater.hpp
  26. item_updater_helper.hpp
  27. item_updater_main.cpp
  28. LICENSE
  29. MAINTAINERS
  30. meson.build
  31. meson_options.txt
  32. msl_verify.cpp
  33. msl_verify.hpp
  34. obmc-flash-bmc
  35. obmc-flash-bmc-setenv@.service.in
  36. obmc-flash-host-bios@.service.in
  37. openssl_alloc.cpp
  38. openssl_alloc.hpp
  39. README.md
  40. reboot-guard-disable.service.in
  41. reboot-guard-enable.service.in
  42. serialize.cpp
  43. serialize.hpp
  44. software.conf
  45. sync_manager.cpp
  46. sync_manager.hpp
  47. sync_manager_main.cpp
  48. sync_watch.cpp
  49. sync_watch.hpp
  50. synclist
  51. usr-local.mount.in
  52. utils.cpp
  53. utils.hpp
  54. version.cpp
  55. version.hpp
  56. watch.cpp
  57. watch.hpp
  58. xyz.openbmc_project.Software.BMC.Updater.service.in
  59. xyz.openbmc_project.Software.Download.service.in
  60. xyz.openbmc_project.Software.Sync.service.in
  61. xyz.openbmc_project.Software.Version.service.in
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

  1. meson build
  2. ninja -C build

To clean the repository run rm -r build.