Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / 8d16554c89b1a0ccd0785e06d48114f635ca5c4f
commit8d16554c89b1a0ccd0785e06d48114f635ca5c4f[log] [tgz]
authorAndrew Geissler <geissonator@yahoo.com>Wed Sep 07 11:05:26 2022 -0400
committerAndrew Geissler <geissonator@yahoo.com>Wed Sep 07 11:09:23 2022 -0400
treeba7e2b8ea48b692e288e28e31fbcbaebbd9cb454
parent124e63beaf84a848d51daaf73065860ec6a0482d [diff]
ensure disable of reboot occurs after enable

Seen a few instances where both the enable and disable service seem to
get queued up at the same time (at least so close together that systemd
sees them as being requested to run at the same time). This results in a
race condition on which runs first. Bad things happen if the disable
happens to get called before the enable.

Put an explicit dependency in the services so if they are both queued at
the same time, they are run in the correct order.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I0c7a04ede468e200b7fa2ca8184907ebeaf82d5d
2 files changed
tree: ba7e2b8ea48b692e288e28e31fbcbaebbd9cb454
  1. mmc/
  2. side-switch/
  3. static/
  4. subprojects/
  5. test/
  6. ubi/
  7. usb/
  8. xyz/
  9. .clang-format
  10. .gitignore
  11. .shellcheck
  12. activation.cpp
  13. activation.hpp
  14. detect-slot-aspeed
  15. download_manager.cpp
  16. download_manager.hpp
  17. download_manager_main.cpp
  18. elog-errors.hpp
  19. flash.hpp
  20. force-reboot.service.in
  21. gen-bios-tar
  22. image_manager.cpp
  23. image_manager.hpp
  24. image_manager_main.cpp
  25. image_verify.cpp
  26. image_verify.hpp
  27. images.cpp
  28. images.hpp
  29. item_updater.cpp
  30. item_updater.hpp
  31. item_updater_helper.hpp
  32. item_updater_main.cpp
  33. LICENSE
  34. meson.build
  35. meson_options.txt
  36. msl_verify.cpp
  37. msl_verify.hpp
  38. obmc-flash-bmc
  39. obmc-flash-bmc-setenv@.service.in
  40. obmc-flash-host-bios@.service.in
  41. openssl_alloc.cpp
  42. openssl_alloc.hpp
  43. OWNERS
  44. README.md
  45. reboot-guard-disable.service.in
  46. reboot-guard-enable.service.in
  47. reset-cs0-aspeed
  48. serialize.cpp
  49. serialize.hpp
  50. software.conf
  51. sync-once.sh
  52. sync_manager.cpp
  53. sync_manager.hpp
  54. sync_manager_main.cpp
  55. sync_watch.cpp
  56. sync_watch.hpp
  57. synclist
  58. usr-local.mount.in
  59. utils.cpp
  60. utils.hpp
  61. version.cpp
  62. version.hpp
  63. watch.cpp
  64. watch.hpp
  65. xyz.openbmc_project.Software.BMC.Updater.service.in
  66. xyz.openbmc_project.Software.Download.service.in
  67. xyz.openbmc_project.Software.Sync.service.in
  68. xyz.openbmc_project.Software.Version.service.in
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

  1. meson build
  2. ninja -C build

To clean the repository run rm -r build.