Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / 88ba1f9ec712d82e8111952df0524bb460c2acb0
commit88ba1f9ec712d82e8111952df0524bb460c2acb0[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Wed Mar 09 21:14:15 2022 +0000
committerAdriana Kobylak <anoo@linux.ibm.com>Thu Mar 10 20:46:27 2022 +0000
tree6ec28c04fe1aa5fec75f92aa16440f0e3bb8af83
parent0b1fd51c744a00c287b6999dde096a91906594aa [diff]
updater: Add activations after versions

When the interfaces added signal is created, it contains all the
interfaces on that path. That means that when the activations map is
created, there's a interfaces added signal with the Activation property
in it. Then if versions is added after that, the interfaces added signal
will list the new properties such as ExtendedVersion, plus the existing
ones like Activation. This causes bmcweb to create 2 tasks for the
update Redfish call because it watches for the Activation property in
the interfaces added signal.

By adding versions first to d-bus, the Version properties are exposed to
d-bus first, then adding activations triggers interfaces added with the
Version properties plus the new Activation ones, so the Activation
property only appears once.

By coincidence, processBMCImage() inserts versions first, then
activations. It was likely not done on purpose but works out and there's
no need to change it there.

Tested: Verified Activation only showed up once in interfaces added with
busctl monitor and verified only one task
(GET https://$bmc/redfish/v1/TaskService/Tasks/) was created when
calling the UpdateService Redfish API.

Change-Id: I3a9e0c109b19ad7ad8d8041404b899a988e14368
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
1 file changed
tree: 6ec28c04fe1aa5fec75f92aa16440f0e3bb8af83
  1. mmc/
  2. static/
  3. subprojects/
  4. test/
  5. ubi/
  6. usb/
  7. xyz/
  8. .clang-format
  9. .gitignore
  10. activation.cpp
  11. activation.hpp
  12. download_manager.cpp
  13. download_manager.hpp
  14. download_manager_main.cpp
  15. elog-errors.hpp
  16. flash.hpp
  17. force-reboot.service.in
  18. gen-bios-tar
  19. image_manager.cpp
  20. image_manager.hpp
  21. image_manager_main.cpp
  22. image_verify.cpp
  23. image_verify.hpp
  24. images.cpp
  25. images.hpp
  26. item_updater.cpp
  27. item_updater.hpp
  28. item_updater_helper.hpp
  29. item_updater_main.cpp
  30. LICENSE
  31. MAINTAINERS
  32. meson.build
  33. meson_options.txt
  34. msl_verify.cpp
  35. msl_verify.hpp
  36. obmc-flash-bmc
  37. obmc-flash-bmc-setenv@.service.in
  38. obmc-flash-host-bios@.service.in
  39. openssl_alloc.cpp
  40. openssl_alloc.hpp
  41. OWNERS
  42. README.md
  43. reboot-guard-disable.service.in
  44. reboot-guard-enable.service.in
  45. serialize.cpp
  46. serialize.hpp
  47. software.conf
  48. sync_manager.cpp
  49. sync_manager.hpp
  50. sync_manager_main.cpp
  51. sync_watch.cpp
  52. sync_watch.hpp
  53. synclist
  54. usr-local.mount.in
  55. utils.cpp
  56. utils.hpp
  57. version.cpp
  58. version.hpp
  59. watch.cpp
  60. watch.hpp
  61. xyz.openbmc_project.Software.BMC.Updater.service.in
  62. xyz.openbmc_project.Software.Download.service.in
  63. xyz.openbmc_project.Software.Sync.service.in
  64. xyz.openbmc_project.Software.Version.service.in
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

  1. meson build
  2. ninja -C build

To clean the repository run rm -r build.