commit 9e307b78659f2c6597f8c66e5d633d7220287d7d
author Pavithra Barithaya <pavithrabarithaya07@gmail.com> Wed Jun 26 01:27:38 2024 -0500
committer Pavithra Barithaya <pavithrabarithaya07@gmail.com> Wed Jul 10 04:43:29 2024 +0000
tree 8e68a485b25aa7c9b00bf10ccfd9b272a70022b3
parent ce9a5c9a69194ed40641c562514599dab4b2fcbf

clang-tidy: Enable readability-string-compare check

This check finds string comparisons using the compare method.
A common mistake is to use the string’s compare method instead of
using the equality or inequality operators.

Change-Id: I261afa51d6af1db5afb94a127f45df7544911af9
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

.clang-tidy

diff --git a/.clang-tidy b/.clang-tidy
index 9ece14b..3856aa5 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -247,6 +247,7 @@
 readability-redundant-preprocessor,
 readability-simplify-subscript-expr,
 readability-static-definition-in-anonymous-namespace,
+readability-string-compare,
 readability-suspicious-call-argument,
 readability-uniqueptr-delete-release,
 readability-uppercase-literal-suffix'

item_updater.cpp

diff --git a/item_updater.cpp b/item_updater.cpp
index 43c4c8b..fd51adb 100644
--- a/item_updater.cpp
+++ b/item_updater.cpp
@@ -685,7 +685,7 @@
 {
     for (auto iter = assocs.begin(); iter != assocs.end();)
     {
-        if ((std::get<2>(*iter)).compare(path) == 0)
+        if (std::get<2>(*iter) == path)
         {
             iter = assocs.erase(iter);
             associations(assocs);