Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / 9eb631da18b9ea58fd3e5b965f930289655db570
commit9eb631da18b9ea58fd3e5b965f930289655db570[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Tue Nov 05 14:10:42 2019 -0600
committerAdriana Kobylak <anoo@us.ibm.com>Thu Nov 07 11:13:22 2019 -0600
tree791fb0dcf710e381cd0001429dbf0080935f91da
parent22848eceb4f19c93b1e3331e52005ce09523637d [diff]
serialize: Replace cereal::RapidJSONException with cereal::Exception

cereal::RapidJSONException is inherited from cereal::Exception.
Currently if the code hits a cereal::Exception, the exception is not
caught and the BMC updater service fails to start. Change it to
catch cereal::Exception, which would also catch cereal::RapidJSONException.

Tested: Caused both kinds of exceptions and verified they were caught.
        Printing the e.what():
        - cereal::Exception - Request non-existent name:
          Nov 04 19:52:22 witherspoon-128-Y330UF73C00D phosphor-image-updater[630]: JSON Parsing failed - provided NVP (purpose) not found
        - cereal::RapidJSONException - Corrupted json:
          Nov 04 19:52:23 witherspoon-128-Y330UF73C00D phosphor-image-updater[630]: rapidjson internal assertion failure: IsObject()

Change-Id: I62a7f4ebf07c4f53db0f77819e43bed773ec9969
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
1 file changed
tree: 791fb0dcf710e381cd0001429dbf0080935f91da
  1. static/
  2. test/
  3. ubi/
  4. xyz/
  5. .clang-format
  6. .gitignore
  7. activation.cpp
  8. activation.hpp
  9. bootstrap.sh
  10. configure.ac
  11. download_manager.cpp
  12. download_manager.hpp
  13. download_manager_main.cpp
  14. elog-errors.hpp
  15. flash.hpp
  16. image_manager.cpp
  17. image_manager.hpp
  18. image_manager_main.cpp
  19. image_verify.cpp
  20. image_verify.hpp
  21. images.hpp
  22. item_updater.cpp
  23. item_updater.hpp
  24. item_updater_helper.hpp
  25. item_updater_main.cpp
  26. LICENSE
  27. MAINTAINERS
  28. Makefile.am
  29. obmc-flash-bmc
  30. obmc-flash-bmc-setenv@.service
  31. openssl_alloc.cpp
  32. openssl_alloc.hpp
  33. README.md
  34. serialize.cpp
  35. serialize.hpp
  36. software.conf
  37. sync_manager.cpp
  38. sync_manager.hpp
  39. sync_manager_main.cpp
  40. sync_watch.cpp
  41. sync_watch.hpp
  42. synclist
  43. usr-local.mount
  44. utils.cpp
  45. utils.hpp
  46. version.cpp
  47. version.hpp
  48. watch.cpp
  49. watch.hpp
  50. xyz.openbmc_project.Software.BMC.Updater.service
  51. xyz.openbmc_project.Software.Download.service
  52. xyz.openbmc_project.Software.Sync.service
  53. xyz.openbmc_project.Software.Version.service
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.