Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / d5b8f75c2f93d19d16411f0846d8ecd331d59562
commitd5b8f75c2f93d19d16411f0846d8ecd331d59562[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Wed May 01 11:52:35 2019 -0500
committerAdriana Kobylak <anoo@us.ibm.com>Tue May 14 13:15:43 2019 -0500
tree0e1fb4ef17101d1a88c18e58fcba0c88cb1e1725
parent9cbfa2efaf65f6c038c77cddf85e9366d90fdeed [diff]
item_updater: Return NotAllowed when attempting to clear FieldMode

Clearing FieldMode used to be a no-op, but by returning success, the
user wouldn't necessarily know that the PUT request did not take effect,
unless they checked the property value.
Changed it to return an error to let the user know that their request
did not take effect.

Tested: Verified an error is returned if the property is requested to
be cleared when it's already set, but no error is returned if it's
already cleared:

$ curl -b cjar -k -H "X-Auth-Token:$sha" -X PUT -d '{"data":"false"}' https://$bmc/xyz/openbmc_project/software/attr/FieldModeEnabled
{
  "data": null,
  "message": "200 OK",
  "status": "ok"
}
$ curl -b cjar -k -H "X-Auth-Token:$sha" -X PUT -d '{"data":"true"}' https://$bmc/xyz/openbmc_project/software/attr/FieldModeEnabled
{
  "data": null,
  "message": "200 OK",
  "status": "ok"
$ curl -b cjar -k -H "X-Auth-Token: $sha" -X PUT -d '{"data":"false"}' https://$bmc/xyz/openbmc_project/software/attr/FieldModeEnabled
{
  "data": {
    "description": "The specified property cannot be created"
  },
  "message": "Input/output error",
  "status": "error"
}

May 01 19:36:16 witherspoon phosphor-image-updater[1465]: The operation is not allowed

"MESSAGE" : "The operation is not allowed",
"REASON" : "FieldMode is not allowed to be cleared",
"SYSLOG_IDENTIFIER" : "phosphor-image-updater",

Change-Id: I1c0226c58956a28d903a85dfe98ac11daca4c7d4
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
1 file changed
tree: 0e1fb4ef17101d1a88c18e58fcba0c88cb1e1725
  1. org/
  2. static/
  3. test/
  4. ubi/
  5. xyz/
  6. .clang-format
  7. .gitignore
  8. activation.cpp
  9. activation.hpp
  10. bootstrap.sh
  11. configure.ac
  12. download_manager.cpp
  13. download_manager.hpp
  14. download_manager_main.cpp
  15. elog-errors.hpp
  16. flash.hpp
  17. image_manager.cpp
  18. image_manager.hpp
  19. image_manager_main.cpp
  20. image_verify.cpp
  21. image_verify.hpp
  22. images.hpp
  23. item_updater.cpp
  24. item_updater.hpp
  25. item_updater_helper.hpp
  26. item_updater_main.cpp
  27. LICENSE
  28. MAINTAINERS
  29. Makefile.am
  30. obmc-flash-bmc
  31. obmc-flash-bmc-setenv@.service
  32. README.md
  33. serialize.cpp
  34. serialize.hpp
  35. software.conf
  36. sync_manager.cpp
  37. sync_manager.hpp
  38. sync_manager_main.cpp
  39. sync_watch.cpp
  40. sync_watch.hpp
  41. synclist
  42. utils.cpp
  43. utils.hpp
  44. version.cpp
  45. version.hpp
  46. watch.cpp
  47. watch.hpp
  48. xyz.openbmc_project.Software.BMC.Updater.service
  49. xyz.openbmc_project.Software.Download.service
  50. xyz.openbmc_project.Software.Sync.service
  51. xyz.openbmc_project.Software.Version.service
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.