Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / a6963590773d4dea762571695e7c47d830aba5d7
commita6963590773d4dea762571695e7c47d830aba5d7[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Fri Sep 07 14:13:29 2018 -0500
committerAdriana Kobylak <anoo@us.ibm.com>Wed Sep 19 11:34:29 2018 -0500
tree1cbd720fe1c248a8e38ef3ff2938ef4f21906d3e
parent1e648729a516d298a3eb1b9b0e88513cee48c7d8 [diff]
Fix being able to activate a Failed version

When an activation fails, the version is marked as Failed.
On a subsequent activation, the bmc updater core dumps due
to 2 issues during the freeSpace call:
1. The Failed activation doesn't have a Priority object, so
default its priority to a large value.
2. If the subsequent activation is to the same version id,
then freeSpace should not do an erase on it, because that
removes the activations object that it's trying to activate.

Tested: Verified that doing an activation after a version
was marked as Failed did not core dump the updater anymore.

Change-Id: Iba36497b53738e00283cfec55e8c666f943cd5d5
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
3 files changed
tree: 1cbd720fe1c248a8e38ef3ff2938ef4f21906d3e
  1. org/
  2. static/
  3. test/
  4. ubi/
  5. xyz/
  6. .clang-format
  7. .gitignore
  8. activation.cpp
  9. activation.hpp
  10. bootstrap.sh
  11. configure.ac
  12. download_manager.cpp
  13. download_manager.hpp
  14. download_manager_main.cpp
  15. elog-errors.hpp
  16. flash.hpp
  17. image_manager.cpp
  18. image_manager.hpp
  19. image_manager_main.cpp
  20. image_verify.cpp
  21. image_verify.hpp
  22. images.hpp
  23. item_updater.cpp
  24. item_updater.hpp
  25. item_updater_helper.hpp
  26. item_updater_main.cpp
  27. LICENSE
  28. MAINTAINERS
  29. Makefile.am
  30. README.md
  31. serialize.cpp
  32. serialize.hpp
  33. sync_manager.cpp
  34. sync_manager.hpp
  35. sync_manager_main.cpp
  36. sync_watch.cpp
  37. sync_watch.hpp
  38. utils.cpp
  39. utils.hpp
  40. version.cpp
  41. version.hpp
  42. watch.cpp
  43. watch.hpp
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.