commit a733df5f73c266aaab8487e1773583c4356367ac
author Gunnar Mills <gmills@us.ibm.com> Tue Apr 11 13:05:52 2017 -0500
committer Patrick Williams <patrick@stwcx.xyz> Thu Apr 27 02:18:03 2017 +0000
tree ff8971e1275a5c1ed7ce6988abbe4ecad3c0f067
parent a927de484b2221ed97ed6f1dc43d4f33624620f5

Create error log on fail

Use elog to create error log on fail.

Change-Id: I27863f5102f56fa04defbab1831c462bf152f771
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

download_manager.cpp

diff --git a/download_manager.cpp b/download_manager.cpp
index 434ece9..f5ff54b 100644
--- a/download_manager.cpp
+++ b/download_manager.cpp
@@ -4,6 +4,9 @@
 #include <sys/wait.h>
 #include <phosphor-logging/log.hpp>
 #include "config.h"
+#include <phosphor-logging/elog.hpp>
+#include <phosphor-logging/elog-errors.hpp>
+#include "xyz/openbmc_project/Common/error.hpp"
 #include "download_manager.hpp"
 
 namespace phosphor
@@ -13,6 +16,7 @@
 namespace manager
 {
 
+using namespace sdbusplus::xyz::openbmc_project::Common::Error;
 using namespace phosphor::logging;
 
 void Download::downloadViaTFTP(const  std::string fileName,
@@ -21,12 +25,20 @@
     if (fileName.empty())
     {
         log<level::ERR>("Error FileName is empty");
+        elog<InvalidArgument>(xyz::openbmc_project::Common::InvalidArgument::
+                              ARGUMENT_NAME("FileName"),
+                              xyz::openbmc_project::Common::InvalidArgument::
+                              ARGUMENT_VALUE(fileName.c_str()));
         return;
     }
 
     if (serverAddress.empty())
     {
         log<level::ERR>("Error ServerAddress is empty");
+        elog<InvalidArgument>(xyz::openbmc_project::Common::InvalidArgument::
+                              ARGUMENT_NAME("ServerAddress"),
+                              xyz::openbmc_project::Common::InvalidArgument::
+                              ARGUMENT_VALUE(serverAddress.c_str()));
         return;
     }
 
@@ -44,10 +56,12 @@
                                             fileName).c_str(), (char*)0);
         // execl only returns on fail
         log<level::ERR>("Error occurred during the TFTP call");
+        elog<InternalFailure>();
     }
     else if (pid < 0)
     {
         log<level::ERR>("Error occurred during fork");
+        elog<InternalFailure>();
     }
 
     return;