Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / 5d9302860ff4b064ae09bb91683cb7fa00ba7450
commit5d9302860ff4b064ae09bb91683cb7fa00ba7450[log] [tgz]
authorLei YU <mine260309@gmail.com>Fri Mar 08 16:41:51 2019 +0800
committerLei YU <mine260309@gmail.com>Tue Apr 02 10:32:49 2019 +0800
treef20a0f3293ecdc13f61b1bf2e5a90f31b6658e7d
parentab8231c66364286a10b0da6d64d9742752323b4d [diff]
Refactor: only untar once

The code in processImage() execute "tar xf" twice, the first time to
extract the MANIFEST, and the second time to extract the whole tarball.

On a tarball without compression, it's OK. But if the tarball is
compressed, it takes much longer time to de-compress the tarball for
twice.

This commit changes the behavior by:
1. Untar the whole tarball into a temp dir;
2. Parse the manifest as before;
3. If something is wrong, remove the temp dir as before;
4. If it's valid, rename the temp dir to the valid image dir.

It also fixes an issue that it uses const_cast in mkdtemp, which is
undefined behavior because the returned const char* shall be read-only,
writing this memory could cause undefined behavior.

Partially resovles openbmc/bmcweb#60

Tested: Verify the image upload works well, and it takes much less time
        on a gzip compressed tarball.

Change-Id: I0af81acbd948e9c54d5d168c9f72e8ebbf8daebe
Signed-off-by: Lei YU <mine260309@gmail.com>
1 file changed
tree: f20a0f3293ecdc13f61b1bf2e5a90f31b6658e7d
  1. org/
  2. static/
  3. test/
  4. ubi/
  5. xyz/
  6. .clang-format
  7. .gitignore
  8. activation.cpp
  9. activation.hpp
  10. bootstrap.sh
  11. configure.ac
  12. download_manager.cpp
  13. download_manager.hpp
  14. download_manager_main.cpp
  15. elog-errors.hpp
  16. flash.hpp
  17. image_manager.cpp
  18. image_manager.hpp
  19. image_manager_main.cpp
  20. image_verify.cpp
  21. image_verify.hpp
  22. images.hpp
  23. item_updater.cpp
  24. item_updater.hpp
  25. item_updater_helper.hpp
  26. item_updater_main.cpp
  27. LICENSE
  28. MAINTAINERS
  29. Makefile.am
  30. README.md
  31. serialize.cpp
  32. serialize.hpp
  33. sync_manager.cpp
  34. sync_manager.hpp
  35. sync_manager_main.cpp
  36. sync_watch.cpp
  37. sync_watch.hpp
  38. utils.cpp
  39. utils.hpp
  40. version.cpp
  41. version.hpp
  42. watch.cpp
  43. watch.hpp
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.