commit a92e727b18ef21087868a0471c21eb5dda802e51
author Alexander Hansen <alexander.hansen@9elements.com> Mon Feb 03 11:16:14 2025 +0100
committer Jagpal S Gill <paligill@gmail.com> Tue Jun 17 17:28:35 2025 +0000
tree ff8cb6cbe65a82d8cbe4e610e81e223d4710333e
parent 692d67ef589c152c58a652537f6a2f1c90d23114

clang-tidy: remove NOLINT for PackageParser

The code for PackageParser was taken from 'pldm' repo, and had to have a
few NOLINT applied for clang-tidy to pass.

Removing those NOLINTs upon request, with minimal code changes.

Change-Id: Iec1937738c7667b0bfbf75b1cb9aa14e93daadb1
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

common/pldm/package_parser.cpp

diff --git a/common/pldm/package_parser.cpp b/common/pldm/package_parser.cpp
index 2fa20e2..7269d42 100644
--- a/common/pldm/package_parser.cpp
+++ b/common/pldm/package_parser.cpp
@@ -8,8 +8,6 @@
 
 #include <memory>
 
-// NOLINTBEGIN
-
 using namespace std;
 
 PHOSPHOR_LOG2_USING;
@@ -347,5 +345,3 @@
 } // namespace fw_update
 
 } // namespace pldm
-
-// NOLINTEND

common/pldm/package_parser.hpp

diff --git a/common/pldm/package_parser.hpp b/common/pldm/package_parser.hpp
index c86cd2f..3f90fb7 100644
--- a/common/pldm/package_parser.hpp
+++ b/common/pldm/package_parser.hpp
@@ -10,8 +10,6 @@
 #include <tuple>
 #include <vector>
 
-// NOLINTBEGIN
-
 namespace pldm
 {
 
@@ -155,7 +153,7 @@
     PackageParserV1(PackageParserV1&&) = default;
     PackageParserV1& operator=(const PackageParserV1&) = delete;
     PackageParserV1& operator=(PackageParserV1&&) = delete;
-    ~PackageParserV1() = default;
+    ~PackageParserV1() override = default;
 
     /** @brief Constructor
      *
@@ -172,7 +170,7 @@
         PackageParser(pkgHeaderSize, pkgVersion, componentBitmapBitLength)
     {}
 
-    virtual void parse(const std::vector<uint8_t>& pkgHdr, uintmax_t pkgSize);
+    void parse(const std::vector<uint8_t>& pkgHdr, uintmax_t pkgSize) override;
 };
 
 /** @brief Parse the package header information
@@ -188,5 +186,3 @@
 } // namespace fw_update
 
 } // namespace pldm
-
-// NOLINTEND

common/pldm/types.hpp

diff --git a/common/pldm/types.hpp b/common/pldm/types.hpp
index 8a8f405..fc08f76 100644
--- a/common/pldm/types.hpp
+++ b/common/pldm/types.hpp
@@ -10,8 +10,6 @@
 #include <variant>
 #include <vector>
 
-// NOLINTBEGIN
-
 namespace pldm
 {
 
@@ -88,5 +86,3 @@
 } // namespace fw_update
 
 } // namespace pldm
-
-// NOLINTEND