commit | aea48f27e46be9454e79a77e3594e021464ec903 | [log] [tgz] |
---|---|---|
author | Adriana Kobylak <anoo@us.ibm.com> | Tue Jul 10 10:20:56 2018 -0500 |
committer | Adriana Kobylak <anoo@us.ibm.com> | Tue Jul 10 10:39:22 2018 -0500 |
tree | 0efb3b02987b12a198bd9ad08a3af5ed2b87b284 | |
parent | 910ce68d2f2aa62dfe18561a7b6e63eed195af35 [diff] |
activation: Improve error handling in Subscribe Handle exceptions from the sdbusplus method call_noreply API. The Activation constructor was subscribing to systemd signals, which would cause an "Already Subscribed" error when creating multiple Activation instances because the bus is common. There is no reason to subscribe to systemd signals in the constructor, since the signals are only triggered during the activation process. Move the Subscribe call to the activation process which calls Unsubscribe at the end. There's a scenario where there could still be an "Already Subscribed" error if the activation fails, so add error handling there. Tested: Verified code update worked with this change, and the app would not core dump with the latest sdbusplus changes. Change-Id: I065baca2586fa64c138d847187303464123cc01a Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture
To build this package, do the following steps: 1. ./bootstrap.sh 2. ./configure ${CONFIGURE_FLAGS} 3. make To clean the repository run `./bootstrap.sh clean`.