commit bddb0a462b01f2582ab43af318fa19580c6e8cd2
author Pavithra Barithaya <pavithrabarithaya07@gmail.com> Wed Jun 26 07:50:38 2024 -0500
committer Pavithra Barithaya <pavithrabarithaya07@gmail.com> Wed Jul 10 05:56:02 2024 +0000
tree b666e5372fd1d879276bd32b50a78b5d79eddf3b
parent 2d5704e62bd2f3216a8aa6f0be4daefaf0274435

clang-tidy: Enable readability-redundant-string-cstr check

This check finds unnecessary calls to std::string::c_str().

Change-Id: I4bf2b9848ad6b6fa748f8e3bdd8d670cdeee90ff
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

.clang-tidy

diff --git a/.clang-tidy b/.clang-tidy
index 1dec9a7..a5de905 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -247,6 +247,7 @@
 readability-redundant-member-init,
 readability-redundant-preprocessor,
 readability-redundant-smartptr-get,
+readability-redundant-string-cstr,
 readability-simplify-boolean-expr,
 readability-simplify-subscript-expr,
 readability-static-definition-in-anonymous-namespace,

side-switch/side_switch.cpp

diff --git a/side-switch/side_switch.cpp b/side-switch/side_switch.cpp
index 25f6fce..6bb3d1d 100644
--- a/side-switch/side_switch.cpp
+++ b/side-switch/side_switch.cpp
@@ -44,7 +44,7 @@
     try
     {
         fwRunningPriority = utils::getProperty<uint8_t>(
-            bus, fwRunningVersionPath.c_str(),
+            bus, fwRunningVersionPath,
             "xyz.openbmc_project.Software.RedundancyPriority", "Priority");
         info("Running firmware version priority is {FW_PRIORITY}",
              "FW_PRIORITY", fwRunningPriority);
@@ -100,8 +100,8 @@
         try
         {
             uint8_t thisPathPri = utils::getProperty<uint8_t>(
-                bus, fwPath.c_str(),
-                "xyz.openbmc_project.Software.RedundancyPriority", "Priority");
+                bus, fwPath, "xyz.openbmc_project.Software.RedundancyPriority",
+                "Priority");
 
             if (thisPathPri < fwRunningPriority)
             {