Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / c31943e11b3e0fc440f34afcdf4498fe2bee9fff
commitc31943e11b3e0fc440f34afcdf4498fe2bee9fff[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Wed Jul 29 12:41:59 2020 -0500
committerAdriana Kobylak <anoo@us.ibm.com>Wed Jul 29 13:30:42 2020 -0500
tree04c2e8525488a1d4a6115061bf1106f7fa31af1f
parent8e9ccfe7362d5fa6a61bb4881a2f0384ca424e84 [diff]
mmc: Remove: Sleep to allow service to finish

There's not currently a good solution for waiting for systemd
service files before returning from a function. The way to achieve
this is to add a sleep before returning.

Need to add a sleep for the mmc remove function to allow the device
to be erased before the update, otherwise the delete and update may
run at the same time causing corruption.

This race condition is not seeing in ubi because the update creates
a new volume for the image, while in the background the old volume
is being erased, although this could still cause issues if space is
tight and the delete is not finished by the time the new image is
written, but this issue hasn't been seen so focusing on mmc only
for this commit.

Tested: Verified no corruption was seen on the tacoma system where
        the issue was reported.

Change-Id: I89eeb97b357cc6a0eb0bf01aa9ac4147cab6168a
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
1 file changed
tree: 04c2e8525488a1d4a6115061bf1106f7fa31af1f
  1. mmc/
  2. static/
  3. test/
  4. ubi/
  5. xyz/
  6. .clang-format
  7. .gitignore
  8. activation.cpp
  9. activation.hpp
  10. download_manager.cpp
  11. download_manager.hpp
  12. download_manager_main.cpp
  13. elog-errors.hpp
  14. flash.hpp
  15. force-reboot.service.in
  16. gen-bios-tar
  17. image_manager.cpp
  18. image_manager.hpp
  19. image_manager_main.cpp
  20. image_verify.cpp
  21. image_verify.hpp
  22. images.cpp
  23. images.hpp
  24. item_updater.cpp
  25. item_updater.hpp
  26. item_updater_helper.hpp
  27. item_updater_main.cpp
  28. LICENSE
  29. MAINTAINERS
  30. meson.build
  31. meson_options.txt
  32. msl_verify.cpp
  33. msl_verify.hpp
  34. obmc-flash-bmc
  35. obmc-flash-bmc-setenv@.service.in
  36. obmc-flash-host-bios@.service.in
  37. openssl_alloc.cpp
  38. openssl_alloc.hpp
  39. README.md
  40. reboot-guard-disable.service.in
  41. reboot-guard-enable.service.in
  42. serialize.cpp
  43. serialize.hpp
  44. software.conf
  45. sync_manager.cpp
  46. sync_manager.hpp
  47. sync_manager_main.cpp
  48. sync_watch.cpp
  49. sync_watch.hpp
  50. synclist
  51. usr-local.mount.in
  52. utils.cpp
  53. utils.hpp
  54. version.cpp
  55. version.hpp
  56. watch.cpp
  57. watch.hpp
  58. xyz.openbmc_project.Software.BMC.Updater.service.in
  59. xyz.openbmc_project.Software.Download.service.in
  60. xyz.openbmc_project.Software.Sync.service.in
  61. xyz.openbmc_project.Software.Version.service.in
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

  1. meson build
  2. ninja -C build

To clean the repository run rm -r build.