commit c5f6e7e1c645281c8af50814f20e9c89dde9156c
author Pavithra Barithaya <pavithrabarithaya07@gmail.com> Mon Jun 24 09:50:21 2024 -0500
committer Pavithra Barithaya <pavithrabarithaya07@gmail.com> Thu Jul 11 15:41:57 2024 +0000
tree 1d576d2d74cba45c08385ded2cd7f6c8ed05de5f
parent bddb0a462b01f2582ab43af318fa19580c6e8cd2

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers readability-static-accessed-through
-instance check as we are trying to access a static member
function through an instance.

Change-Id: Ia0867db019db8e40e710bdd4025e030061f7a992
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

item_updater.cpp

diff --git a/item_updater.cpp b/item_updater.cpp
index 2215b71..641a2a5 100644
--- a/item_updater.cpp
+++ b/item_updater.cpp
@@ -560,7 +560,7 @@
 
 void ItemUpdater::reset()
 {
-    helper.factoryReset();
+    phosphor::software::updater::Helper::factoryReset();
 
     info("BMC factory reset will take effect upon reboot.");
 }