commit c5f6e7e1c645281c8af50814f20e9c89dde9156c
author Pavithra Barithaya <pavithrabarithaya07@gmail.com> Mon Jun 24 09:50:21 2024 -0500
committer Pavithra Barithaya <pavithrabarithaya07@gmail.com> Thu Jul 11 15:41:57 2024 +0000
tree 1d576d2d74cba45c08385ded2cd7f6c8ed05de5f
parent bddb0a462b01f2582ab43af318fa19580c6e8cd2

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers readability-static-accessed-through
-instance check as we are trying to access a static member
function through an instance.

Change-Id: Ia0867db019db8e40e710bdd4025e030061f7a992
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

sync_manager_main.cpp

diff --git a/sync_manager_main.cpp b/sync_manager_main.cpp
index 758abcf..8f70fe4 100644
--- a/sync_manager_main.cpp
+++ b/sync_manager_main.cpp
@@ -22,12 +22,10 @@
 
     try
     {
-        phosphor::software::manager::Sync syncManager;
-
         using namespace phosphor::software::manager;
-        phosphor::software::manager::SyncWatch watch(
-            *loop, std::bind(std::mem_fn(&Sync::processEntry), &syncManager,
-                             std::placeholders::_1, std::placeholders::_2));
+        auto syncCallback = std::bind(
+            &Sync::processEntry, std::placeholders::_1, std::placeholders::_2);
+        phosphor::software::manager::SyncWatch watch(*loop, syncCallback);
         bus.attach_event(loop, SD_EVENT_PRIORITY_NORMAL);
         sd_event_loop(loop);
     }