Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / 341243513d6da6e9d3ddf886c0d22029fad748a9
commit341243513d6da6e9d3ddf886c0d22029fad748a9[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Fri May 22 09:40:40 2020 -0500
committerAdriana Kobylak <anoo@linux.ibm.com>Tue Jul 14 14:09:57 2020 +0000
tree072e6fab3214044bc70f2291af5c13422c24c8d1
parent70f5bc04d82ac9c236f13e825db31e7c96aa7f11 [diff]
mmc: Set updated version to primary

Once the update is successful, mark the version as primary so that
it boots from the updated version upon BMC reboot.

Add a sleep to wait for the service file to complete setting the
primary version. Otherwise, the BMC could mark a Delete or
Priority value change as complete and the service is not done yet,
and if the BMC is rebooted it could try to boot from a non-existent
version.

As backgroung, reference issue openbmc/openbmc#2857 that attempted
to create a 'wait for service' function but was not successful.
This could be investigated further at a later time, which would
benefit other functions like Factory Reset that are also using
sleep as a workaround to wait for systemd service files.

Tested: Verified the version was set to primary during code update
        and delete, and that 3s passed (service file finished in
        about 1s) before the delete/update continued.

Change-Id: I4f9afdb020d8cc7c18cfdafe468dbff2dc8046c1
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
5 files changed
tree: 072e6fab3214044bc70f2291af5c13422c24c8d1
  1. mmc/
  2. static/
  3. test/
  4. ubi/
  5. xyz/
  6. .clang-format
  7. .gitignore
  8. activation.cpp
  9. activation.hpp
  10. download_manager.cpp
  11. download_manager.hpp
  12. download_manager_main.cpp
  13. elog-errors.hpp
  14. flash.hpp
  15. force-reboot.service.in
  16. gen-bios-tar
  17. image_manager.cpp
  18. image_manager.hpp
  19. image_manager_main.cpp
  20. image_verify.cpp
  21. image_verify.hpp
  22. images.hpp
  23. item_updater.cpp
  24. item_updater.hpp
  25. item_updater_helper.hpp
  26. item_updater_main.cpp
  27. LICENSE
  28. MAINTAINERS
  29. meson.build
  30. meson_options.txt
  31. obmc-flash-bmc
  32. obmc-flash-bmc-setenv@.service.in
  33. obmc-flash-host-bios@.service.in
  34. openssl_alloc.cpp
  35. openssl_alloc.hpp
  36. README.md
  37. reboot-guard-disable.service.in
  38. reboot-guard-enable.service.in
  39. serialize.cpp
  40. serialize.hpp
  41. software.conf
  42. sync_manager.cpp
  43. sync_manager.hpp
  44. sync_manager_main.cpp
  45. sync_watch.cpp
  46. sync_watch.hpp
  47. synclist
  48. usr-local.mount.in
  49. utils.cpp
  50. utils.hpp
  51. version.cpp
  52. version.hpp
  53. watch.cpp
  54. watch.hpp
  55. xyz.openbmc_project.Software.BMC.Updater.service.in
  56. xyz.openbmc_project.Software.Download.service.in
  57. xyz.openbmc_project.Software.Sync.service.in
  58. xyz.openbmc_project.Software.Version.service.in
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

  1. meson build
  2. ninja -C build

To clean the repository run rm -r build.