Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / dcfadad5acc06010ef3b58004ca36833e0e316f1
commitdcfadad5acc06010ef3b58004ca36833e0e316f1[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Tue May 23 20:41:38 2023 +0000
committerAdriana Kobylak <anoo@linux.ibm.com>Mon Jun 05 20:18:52 2023 +0000
treee523f0e8fb6eb4557b4d9b9751383c7b35798cd4
parentb36a3ebfa48a18eff75b9b1b0c27bb068d998237 [diff]
mmc: Run fsck on the alternate image and hostfw

Before mounting the alternate image, run fsck on it to determine if the
filesystem is corrupted, this could happen if the BMC rebooted in the
middle of a code update for example. Invalidate the image if it's found
to be corrupted.

Run fsck on the hostfw partition too, this is a writable partition that
can benefit from autocorrection. The mmc initramfs runs fsck on the rwfs
partition already. It's a good practice to run fsck on writable
partitions. Do not fail if fsck fails on the hostfw partition, if it's
corrupted, an error would occur during the power on.

Tested: Verified there were no errors with this change. This change adds
about 1s to the execution of the mount service, from 5s to 6s to start:

May 24 19:07:27 p10bmc systemd[1]: Starting Mount BMC rofs volumes
after a reboot...
May 24 19:07:27 p10bmc obmc-flash-bmc[328]:
/dev/disk/by-partlabel/rofs-a: clean, 6430/68816 files, 192421/275012
blocks
May 24 19:07:27 p10bmc kernel: EXT4-fs (mmcblk0p4): mounted
filesystem with ordered data mode. Quota mode: disabled.
May 24 19:07:33 p10bmc fsck.ext4[474]: hostfw: clean, 247/655360
files, 196363/1310720 blocks
May 24 19:07:34 p10bmc kernel: EXT4-fs (mmcblk0p7): mounted
filesystem with ordered data mode. Quota mode: disabled.
May 24 19:07:34 p10bmc systemd[1]: obmc-flash-mmc-mount.service:
Deactivated successfully.
May 24 19:07:34 p10bmc systemd[1]: Finished Mount BMC rofs volumes
after a reboot.

Change-Id: I0efedb6d72e1d0d6018974598c4b361eafe7441b
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
2 files changed
tree: e523f0e8fb6eb4557b4d9b9751383c7b35798cd4
  1. mmc/
  2. side-switch/
  3. static/
  4. subprojects/
  5. test/
  6. ubi/
  7. usb/
  8. xyz/
  9. .clang-format
  10. .gitignore
  11. .shellcheck
  12. activation.cpp
  13. activation.hpp
  14. detect-slot-aspeed
  15. download_manager.cpp
  16. download_manager.hpp
  17. download_manager_main.cpp
  18. elog-errors.hpp
  19. flash.hpp
  20. force-reboot.service.in
  21. gen-bios-tar
  22. image_manager.cpp
  23. image_manager.hpp
  24. image_manager_main.cpp
  25. image_verify.cpp
  26. image_verify.hpp
  27. images.cpp
  28. images.hpp
  29. item_updater.cpp
  30. item_updater.hpp
  31. item_updater_helper.hpp
  32. item_updater_main.cpp
  33. LICENSE
  34. meson.build
  35. meson_options.txt
  36. msl_verify.cpp
  37. msl_verify.hpp
  38. obmc-flash-bmc
  39. obmc-flash-bmc-setenv@.service.in
  40. obmc-flash-host-bios@.service.in
  41. openssl_alloc.cpp
  42. openssl_alloc.hpp
  43. OWNERS
  44. README.md
  45. reboot-guard-disable.service.in
  46. reboot-guard-enable.service.in
  47. reset-cs0-aspeed
  48. serialize.cpp
  49. serialize.hpp
  50. software.conf
  51. sync-once.sh
  52. sync_manager.cpp
  53. sync_manager.hpp
  54. sync_manager_main.cpp
  55. sync_watch.cpp
  56. sync_watch.hpp
  57. synclist
  58. usr-local.mount.in
  59. utils.cpp
  60. utils.hpp
  61. version.cpp
  62. version.hpp
  63. watch.cpp
  64. watch.hpp
  65. xyz.openbmc_project.Software.BMC.Updater.service.in
  66. xyz.openbmc_project.Software.Download.service.in
  67. xyz.openbmc_project.Software.Sync.service.in
  68. xyz.openbmc_project.Software.Version.service.in
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

  1. meson build
  2. ninja -C build

To clean the repository run rm -r build.