Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / e56bf8785f0831e2210371296b70b6085f36f56e
commite56bf8785f0831e2210371296b70b6085f36f56e[log] [tgz]
authorLei YU <yulei.sh@bytedance.com>Tue Feb 22 18:40:37 2022 +0800
committerLei YU <yulei.sh@bytedance.com>Mon Mar 14 13:44:54 2022 +0800
tree0d55de354660046d0583bf9f92c9c6f0a6578734
parentd474d9cde4b630172afb92b43b270e1f3e7bd5ea [diff]
dual-image: Do not erase image if os-release is not found

The code will erase an image if the os-release is not found.
For dual image, the secondary flash may be empty or contains invalid
data, e.g. in factory or lab, so it should just ignore such case instead
of erasing the image.

Without the change, when it tries to erase the image, it crashes in
erase() because the version ID is not available and the code was
accessing the invalidated iterator.

Tested: Verify the crash is fixed in QEMU when the secondary image is
        empty.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I7a1a8da15c31045fc7d51416f6ba0875349067d2
1 file changed
tree: 0d55de354660046d0583bf9f92c9c6f0a6578734
  1. mmc/
  2. static/
  3. subprojects/
  4. test/
  5. ubi/
  6. usb/
  7. xyz/
  8. .clang-format
  9. .gitignore
  10. activation.cpp
  11. activation.hpp
  12. download_manager.cpp
  13. download_manager.hpp
  14. download_manager_main.cpp
  15. elog-errors.hpp
  16. flash.hpp
  17. force-reboot.service.in
  18. gen-bios-tar
  19. image_manager.cpp
  20. image_manager.hpp
  21. image_manager_main.cpp
  22. image_verify.cpp
  23. image_verify.hpp
  24. images.cpp
  25. images.hpp
  26. item_updater.cpp
  27. item_updater.hpp
  28. item_updater_helper.hpp
  29. item_updater_main.cpp
  30. LICENSE
  31. MAINTAINERS
  32. meson.build
  33. meson_options.txt
  34. msl_verify.cpp
  35. msl_verify.hpp
  36. obmc-flash-bmc
  37. obmc-flash-bmc-setenv@.service.in
  38. obmc-flash-host-bios@.service.in
  39. openssl_alloc.cpp
  40. openssl_alloc.hpp
  41. OWNERS
  42. README.md
  43. reboot-guard-disable.service.in
  44. reboot-guard-enable.service.in
  45. serialize.cpp
  46. serialize.hpp
  47. software.conf
  48. sync_manager.cpp
  49. sync_manager.hpp
  50. sync_manager_main.cpp
  51. sync_watch.cpp
  52. sync_watch.hpp
  53. synclist
  54. usr-local.mount.in
  55. utils.cpp
  56. utils.hpp
  57. version.cpp
  58. version.hpp
  59. watch.cpp
  60. watch.hpp
  61. xyz.openbmc_project.Software.BMC.Updater.service.in
  62. xyz.openbmc_project.Software.Download.service.in
  63. xyz.openbmc_project.Software.Sync.service.in
  64. xyz.openbmc_project.Software.Version.service.in
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

  1. meson build
  2. ninja -C build

To clean the repository run rm -r build.