Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / 5a7363b4cfdf995a6bebb80b6fe1cd3514c593a6
commit5a7363b4cfdf995a6bebb80b6fe1cd3514c593a6[log] [tgz]
authorLei YU <mine260309@gmail.com>Fri Oct 18 16:50:59 2019 +0800
committerLei YU <mine260309@gmail.com>Wed Oct 23 07:15:55 2019 +0000
tree3fef6a8ff618c114db704dbe61d9eac8f2d2387b
parentb7c062ef6ce40aacce19f05724d6670d14ce13a2 [diff]
Version: support CRLF line feed in MANIFEST

When a MANIFEST is generated from Windows and it contains CRLF as line
feed, the code was getting each line with '\r' at the end, and thus the
parsed string contains '\r' and it incorrectly parses the string.

Add a piece of code to support CRLF line feed so support such MANIFEST
files.

Tested: Update the unit test case to verify CRLF is correctly handled.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: I872bb59dbde5647e833f5c335357a3f6ae0765a5
2 files changed
tree: 3fef6a8ff618c114db704dbe61d9eac8f2d2387b
  1. static/
  2. test/
  3. ubi/
  4. xyz/
  5. .clang-format
  6. .gitignore
  7. activation.cpp
  8. activation.hpp
  9. bootstrap.sh
  10. configure.ac
  11. download_manager.cpp
  12. download_manager.hpp
  13. download_manager_main.cpp
  14. elog-errors.hpp
  15. flash.hpp
  16. image_manager.cpp
  17. image_manager.hpp
  18. image_manager_main.cpp
  19. image_verify.cpp
  20. image_verify.hpp
  21. images.hpp
  22. item_updater.cpp
  23. item_updater.hpp
  24. item_updater_helper.hpp
  25. item_updater_main.cpp
  26. LICENSE
  27. MAINTAINERS
  28. Makefile.am
  29. obmc-flash-bmc
  30. obmc-flash-bmc-setenv@.service
  31. openssl_alloc.cpp
  32. openssl_alloc.hpp
  33. README.md
  34. serialize.cpp
  35. serialize.hpp
  36. software.conf
  37. sync_manager.cpp
  38. sync_manager.hpp
  39. sync_manager_main.cpp
  40. sync_watch.cpp
  41. sync_watch.hpp
  42. synclist
  43. utils.cpp
  44. utils.hpp
  45. version.cpp
  46. version.hpp
  47. watch.cpp
  48. watch.hpp
  49. xyz.openbmc_project.Software.BMC.Updater.service
  50. xyz.openbmc_project.Software.Download.service
  51. xyz.openbmc_project.Software.Sync.service
  52. xyz.openbmc_project.Software.Version.service
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.