Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / cfb4b2099f840f75aebd4b8ce9a054aa2b62ad2a
commitcfb4b2099f840f75aebd4b8ce9a054aa2b62ad2a[log] [tgz]
authorLei YU <yulei.sh@bytedance.com>Thu May 06 17:47:28 2021 +0800
committerLei YU <yulei.sh@bytedance.com>Thu May 06 18:34:45 2021 +0800
tree27ac4d817a834ddb8f1e13921128f0bd929ba5c5
parent6e9fb1d6ec428d1cc05c78b9b394b214b46c0364 [diff]
item_updater: Fix crash on redundantPriority

When the BIOS update is enabled, the activation of the BIOS does not
have redundantPriority.
After BIOS update, the code will have an activation without
redundantPriority.
In such case, the BMC update will fail due to the crash in freeSpace()
that uses the redundantPriority.

Fix it by checking if the redundantPriority is null or not, and skip
the activations that has no redundantPriority.

Tested: Verify the phosphor-image-updater does not crash on the above
        case.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I92ac9e0f9f02067ceefd0011d01464e8bbd743a5
1 file changed
tree: 27ac4d817a834ddb8f1e13921128f0bd929ba5c5
  1. mmc/
  2. static/
  3. test/
  4. ubi/
  5. xyz/
  6. .clang-format
  7. .gitignore
  8. activation.cpp
  9. activation.hpp
  10. download_manager.cpp
  11. download_manager.hpp
  12. download_manager_main.cpp
  13. elog-errors.hpp
  14. flash.hpp
  15. force-reboot.service.in
  16. gen-bios-tar
  17. image_manager.cpp
  18. image_manager.hpp
  19. image_manager_main.cpp
  20. image_verify.cpp
  21. image_verify.hpp
  22. images.cpp
  23. images.hpp
  24. item_updater.cpp
  25. item_updater.hpp
  26. item_updater_helper.hpp
  27. item_updater_main.cpp
  28. LICENSE
  29. MAINTAINERS
  30. meson.build
  31. meson_options.txt
  32. msl_verify.cpp
  33. msl_verify.hpp
  34. obmc-flash-bmc
  35. obmc-flash-bmc-setenv@.service.in
  36. obmc-flash-host-bios@.service.in
  37. openssl_alloc.cpp
  38. openssl_alloc.hpp
  39. README.md
  40. reboot-guard-disable.service.in
  41. reboot-guard-enable.service.in
  42. serialize.cpp
  43. serialize.hpp
  44. software.conf
  45. sync_manager.cpp
  46. sync_manager.hpp
  47. sync_manager_main.cpp
  48. sync_watch.cpp
  49. sync_watch.hpp
  50. synclist
  51. usr-local.mount.in
  52. utils.cpp
  53. utils.hpp
  54. version.cpp
  55. version.hpp
  56. watch.cpp
  57. watch.hpp
  58. xyz.openbmc_project.Software.BMC.Updater.service.in
  59. xyz.openbmc_project.Software.Download.service.in
  60. xyz.openbmc_project.Software.Sync.service.in
  61. xyz.openbmc_project.Software.Version.service.in
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

  1. meson build
  2. ninja -C build

To clean the repository run rm -r build.