commit 78a224bd19968f1915baa6b196f0b9d3cc15b968
author Patrick Williams <patrick@stwcx.xyz> Fri Feb 23 19:10:19 2024 -0600
committer Patrick Williams <patrick@stwcx.xyz> Fri Feb 23 20:42:16 2024 -0600
tree cb878f60266491c97777bdbc59fb03fd063511a7
parent b3a8df26c73c467cbaa68ea83c70e011b546bb9e

metric-config: remove the free-memory threshold

By default we have a metric on the available memory.  Free memory should
be a subset of available memory.  You can have some memory held by
kernel caches that can be evicted as needed, which show up in available
and not free.  Having a threshold on free memory is probably not what
anyone wants by default, so remove it from the default config.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I16d15266b6e10e6c7a788095b4b29d5e603e102c

health_metric_config.cpp

diff --git a/health_metric_config.cpp b/health_metric_config.cpp
index 6360203..68cb0cd 100644
--- a/health_metric_config.cpp
+++ b/health_metric_config.cpp
@@ -234,14 +234,7 @@
     },
     "Memory_Free": {
         "Frequency": 1,
-        "Window_size": 120,
-        "Threshold": {
-            "Critical_Lower": {
-                "Value": 15.0,
-                "Log": true,
-                "Target": ""
-            }
-        }
+        "Window_size": 120
     },
     "Memory_Shared": {
         "Frequency": 1,

test/test_health_metric_collection.cpp

diff --git a/test/test_health_metric_collection.cpp b/test/test_health_metric_collection.cpp
index e9aa000..538668b 100644
--- a/test/test_health_metric_collection.cpp
+++ b/test/test_health_metric_collection.cpp
@@ -159,7 +159,7 @@
                 sd_bus_message_new_signal(IsNull(), NotNull(), NotNull(),
                                           StrEq(thresholdInterface),
                                           StrEq("AssertionChanged")))
-        .Times(8);
+        .Times(7);
 
     createCollection();
 }