commit e7b17de98cb780029391f42df132379490a162c6
author Patrick Williams <patrick@stwcx.xyz> Fri Feb 23 19:12:14 2024 -0600
committer Patrick Williams <patrick@stwcx.xyz> Fri Feb 23 20:42:16 2024 -0600
tree 34e5e533f21bed5836837dc1a835a7a8ca65e4bb
parent 78a224bd19968f1915baa6b196f0b9d3cc15b968

metric-config: remove the buffer/cache-memory threshold

The kernel will naturally attempt to use almost all free memory up with
buffers and caches.  We should not have a threshold on this behavior
by default.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic40a260667e89d62820e99753efda025ba5bde47

health_metric_config.cpp

diff --git a/health_metric_config.cpp b/health_metric_config.cpp
index 68cb0cd..8a2d5e7 100644
--- a/health_metric_config.cpp
+++ b/health_metric_config.cpp
@@ -249,14 +249,7 @@
     },
     "Memory_Buffered_And_Cached": {
         "Frequency": 1,
-        "Window_size": 120,
-        "Threshold": {
-            "Critical_Upper": {
-                "Value": 85.0,
-                "Log": true,
-                "Target": ""
-            }
-        }
+        "Window_size": 120
     },
     "Storage_RW": {
         "Path": "/run/initramfs/rw",

test/test_health_metric_collection.cpp

diff --git a/test/test_health_metric_collection.cpp b/test/test_health_metric_collection.cpp
index 538668b..dc15f07 100644
--- a/test/test_health_metric_collection.cpp
+++ b/test/test_health_metric_collection.cpp
@@ -159,7 +159,7 @@
                 sd_bus_message_new_signal(IsNull(), NotNull(), NotNull(),
                                           StrEq(thresholdInterface),
                                           StrEq("AssertionChanged")))
-        .Times(7);
+        .Times(6);
 
     createCollection();
 }