Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / ebc886fc52d3f109e4c3b4ee74a510c65557eebe
commitebc886fc52d3f109e4c3b4ee74a510c65557eebe[log] [tgz]
authorRichard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>Wed Jun 06 14:33:59 2018 +0530
committerVernon Mauery <vernon.mauery@linux.intel.com>Tue Jul 24 20:10:39 2018 +0000
tree53bb3aa41b434a10f8d54ba32557daa13aa7f4f1
parent1469f8adc101962c1235f9477e9d53b5ba44e72b [diff]
Fix to return sane error code

Any unhandled exception in the IPMI command handler
crashes the ipmi stack. IPMI command handler also becomes
bulky to catch all exceptions which must return unspecified
errors. This fix adds a catch in the ipmi router command handler
functions, and returns IPMI_CC_UNSPECIFIED_ERROR for all the
unhandled exceptions. With this fix, exceptions which has to
throw IPMI_CC_UNSPECIFIED_ERROR, doesn't needs to be handled in the
command handlers.

Change-Id: I6cf9fa1f0e5c1d71c57eebb9a2d451fa986168d3
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
1 file changed
tree: 53bb3aa41b434a10f8d54ba32557daa13aa7f4f1
  1. app/
  2. docs/
  3. host-ipmid/
  4. scripts/
  5. softoff/
  6. test/
  7. xyz/
  8. .build.sh
  9. .gitignore
  10. .travis.yml
  11. apphandler.cpp
  12. apphandler.h
  13. bootstrap.sh
  14. chassishandler.cpp
  15. chassishandler.h
  16. configure.ac
  17. dcmihandler.cpp
  18. dcmihandler.hpp
  19. elog-errors.hpp
  20. error-HostEvent.hpp
  21. fruread.hpp
  22. generate_whitelist.sh
  23. globalhandler.cpp
  24. globalhandler.h
  25. groupext.cpp
  26. host-cmd-manager.cpp
  27. host-cmd-manager.hpp
  28. host-interface.cpp
  29. host-interface.hpp
  30. host-ipmid-whitelist.conf
  31. ipmi_fru_info_area.cpp
  32. ipmi_fru_info_area.hpp
  33. ipmid.cpp
  34. ipmid.hpp
  35. ipmisensor.cpp
  36. ipmiwhitelist.hpp
  37. LICENSE
  38. MAINTAINERS
  39. Makefile.am
  40. net.cpp
  41. net.hpp
  42. read_fru_data.cpp
  43. read_fru_data.hpp
  44. README.md
  45. sample.cpp
  46. sample.h
  47. selutility.cpp
  48. selutility.hpp
  49. sensordatahandler.cpp
  50. sensordatahandler.hpp
  51. sensorhandler.cpp
  52. sensorhandler.h
  53. settings.cpp
  54. settings.hpp
  55. storageaddsel.cpp
  56. storageaddsel.h
  57. storagehandler.cpp
  58. storagehandler.h
  59. systemintfcmds.cpp
  60. systemintfcmds.h
  61. testaddsel.cpp
  62. testit.cpp
  63. timer.cpp
  64. timer.hpp
  65. transporthandler.cpp
  66. transporthandler.hpp
  67. types.hpp
  68. utils.cpp
  69. utils.hpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.