Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 5ed395951d17f4f2616c21345cd6652779c8b300
commit5ed395951d17f4f2616c21345cd6652779c8b300[log] [tgz]
authorVernon Mauery <vernon.mauery@linux.intel.com>Tue May 14 09:16:53 2019 -0700
committerVernon Mauery <vernon.mauery@linux.intel.com>Fri May 17 18:23:04 2019 +0000
tree707d33e9a1390850b3cd25956ffafe175459bd98
parent6d5b2f7e1c6e142b6198be45e3766d7d8cf5c9bc [diff]
Update current channel mechanism to be usable by netipmid

Getting the current channel is really just an if statement for the
requested channel (check for 0x0e) to know if the device channel
which is determined by -c <channel> by netipmid and by dbus names
in host ipmid. Previously, an ipmi::Context was passed in, but
netipmid does not use Context, it just has the channel number. So
This change makes it so the the requested channel number and the
device channel number are the arguments, which makes the same
function usable in both netipmid and ipmid.

Tested-by: run the get user access command to see that it uses the
           current channel.

           # remote connection over channel 1
           ipmitool -I lanplus -H <> ... raw 6 0x44 0xe 1
            0f 41 00 74
           ipmitool -I lanplus -H <> ... raw 6 0x44 1 1
            0f 41 00 74

           # on bmc console (current channel does not use users)
           ipmitool raw 6 0x44 0xe 1
            Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
            cmd=0x44 rsp=0xcc): Invalid data field in request
           # request info for channel 1
           ipmitool raw 6 0x44 1 1
            0f 41 00 74

Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
Change-Id: Iadad6f93e47d031a6f4724a3db5161051c5b520a
2 files changed
tree: 707d33e9a1390850b3cd25956ffafe175459bd98
  1. app/
  2. docs/
  3. include/
  4. libipmid/
  5. libipmid-host/
  6. scripts/
  7. softoff/
  8. test/
  9. user_channel/
  10. xyz/
  11. .build.sh
  12. .clang-format
  13. .gitignore
  14. .travis.yml
  15. apphandler.cpp
  16. apphandler.hpp
  17. bootstrap.sh
  18. chassishandler.cpp
  19. chassishandler.hpp
  20. configure.ac
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. error-HostEvent.hpp
  25. fruread.hpp
  26. generate_whitelist.sh
  27. globalhandler.cpp
  28. globalhandler.hpp
  29. groupext.cpp
  30. host-cmd-manager.cpp
  31. host-cmd-manager.hpp
  32. host-interface.cpp
  33. host-interface.hpp
  34. host-ipmid-whitelist.conf
  35. ipmi_fru_info_area.cpp
  36. ipmi_fru_info_area.hpp
  37. ipmid-new.cpp
  38. ipmisensor.cpp
  39. ipmiwhitelist.hpp
  40. LICENSE
  41. MAINTAINERS
  42. Makefile.am
  43. oemrouter.cpp
  44. read_fru_data.cpp
  45. read_fru_data.hpp
  46. README.md
  47. sample.cpp
  48. sample.h
  49. selutility.cpp
  50. selutility.hpp
  51. sensordatahandler.cpp
  52. sensordatahandler.hpp
  53. sensorhandler.cpp
  54. sensorhandler.hpp
  55. settings.cpp
  56. settings.hpp
  57. storageaddsel.cpp
  58. storageaddsel.hpp
  59. storagehandler.cpp
  60. storagehandler.hpp
  61. sys_info_param.cpp
  62. sys_info_param.hpp
  63. systemintfcmds.cpp
  64. systemintfcmds.hpp
  65. testaddsel.cpp
  66. testit.cpp
  67. transporthandler.cpp
  68. transporthandler.hpp
  69. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.