Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 6d4a44ed2bbfdac7c20029bf212eb2b60ecefbc4
commit6d4a44ed2bbfdac7c20029bf212eb2b60ecefbc4[log] [tgz]
authorJiaqing Zhao <jiaqing.zhao@intel.com>Mon Jan 24 15:04:00 2022 +0800
committerVernon Mauery <vernon.mauery@linux.intel.com>Wed Apr 13 00:46:49 2022 +0000
tree203002ea98b253e9d238dc8b39f074de752f8ced
parent23f44657333de5e01ba4b78a4b14e57c42188ef8 [diff]
Check prefix length in Set LAN Config Param 6 & 56

In phosphor-networkd, the allowed prefix length is 1 to 32 for IPv4 and
1 to 128 for IPv6. Calling DBus API with an invalid prefix length will
result in uncaught exceptions. This patch checks prefix length before
setting it and returns appropriate error code on invalid value.

Tested:
* Setting IPv4 SubnetMask to 0.0.0.0 (Param 6) returns 0xcc.
* Setting IPv6 static address with PrefixLength==129 (Param 56) returns
  0xc9.

Change-Id: I03af233905e415c96c896c85baf98846d0880e95
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>
2 files changed
tree: 203002ea98b253e9d238dc8b39f074de752f8ced
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. libipmid-host/
  7. scripts/
  8. softoff/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. bootstrap.sh
  20. chassishandler.cpp
  21. chassishandler.hpp
  22. configure.ac
  23. dcmihandler.cpp
  24. dcmihandler.hpp
  25. elog-errors.hpp
  26. entity_map_json.cpp
  27. entity_map_json.hpp
  28. error-HostEvent.hpp
  29. fruread.hpp
  30. generate_whitelist.sh
  31. globalhandler.cpp
  32. globalhandler.hpp
  33. groupext.cpp
  34. host-cmd-manager.cpp
  35. host-cmd-manager.hpp
  36. host-interface.cpp
  37. host-interface.hpp
  38. host-ipmid-whitelist.conf
  39. ipmi_fru_info_area.cpp
  40. ipmi_fru_info_area.hpp
  41. ipmid-new.cpp
  42. ipmisensor.cpp
  43. ipmiwhitelist.hpp
  44. LICENSE
  45. MAINTAINERS
  46. Makefile.am
  47. OWNERS
  48. read_fru_data.cpp
  49. read_fru_data.hpp
  50. README.md
  51. sample.cpp
  52. sample.h
  53. selutility.cpp
  54. selutility.hpp
  55. sensordatahandler.cpp
  56. sensordatahandler.hpp
  57. sensorhandler.cpp
  58. sensorhandler.hpp
  59. settings.cpp
  60. settings.hpp
  61. storageaddsel.cpp
  62. storageaddsel.hpp
  63. storagehandler.cpp
  64. storagehandler.hpp
  65. sys_info_param.cpp
  66. sys_info_param.hpp
  67. systemintfcmds.cpp
  68. systemintfcmds.hpp
  69. testaddsel.cpp
  70. testit.cpp
  71. transporthandler.cpp
  72. transporthandler.hpp
  73. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.